A null parameter should throw ArgumentNullException

[tsahi]

at

Sander.KeyVaultCache/Sander.KeyVaultCache/KeyVaultCache.cs

Line 26 in a3023ea

throw new NullReferenceException($"{nameof(keyVaultClient)} is null!");

A NullReferenceException is thrown. In this case, an ArgumentNullException should be thrown. The parameter name should be set to the paramName pareameter of the ArgumentNullException constructor.

Similarly, at

Sander.KeyVaultCache/Sander.KeyVaultCache/KeyFetcher.cs

Line 70 in a3023ea

throw new NullReferenceException($"Key Vault request {typeof(T).Name} for \"{name}\" returned null!");

A NullReferenceException is thrown although some other, perhaps a custom application exception, should be thrown.

[SanderSade]

Good catch for the first - I will change this in a day or few. Not sure if it is worth to do a new release, though.

On second, I have a deep dislike of custom exceptions, due to a huge project that used custom exceptions as a way to control the business logic. Perhaps KeyVaultErrorException?

[tsahi]

KeyVaultErrorException derives from RestException, which describes a REST error, which is not the case here. Regardless of your personal past experience, I still believe a custom exception is in place here.