Tiny fix

Author: parttimenerd

.github/workflows/build-and-snapshot-enhanced.yml

@@ -48,7 +48,7 @@ jobs:
       - name: Run Python linting
         if: steps.check-tests.outputs.tests_exist == 'true'
         run: |
-          cd testing
+          cd test
           source venv/bin/activate
           echo "🔍 Running flake8..."
           flake8 --max-line-length=120 --ignore=E203,W503 . || exit 1

CI-TESTING-INTEGRATION.md

@@ -105,7 +105,7 @@ git push origin feature-branch
 ./test-vscode-config.sh
 
 # Run specific tests
-cd testing && pytest test_jfr.py -v
+cd test && pytest test_jfr.py -v
 ```
 
 ## 📊 Quality Metrics

test/framework/decorators.py

@@ -16,7 +16,7 @@ def test(*apps, no_restart=False):
     """Test decorator.
 
     Usage:
-        @test
+        @test()
         @test(no_restart=True)  # Skip app restart after test
 
     Args:

test/framework/dsl.py

@@ -29,12 +29,15 @@ def should_succeed(self) -> "FluentAssertion":
         """Assert that the command succeeded."""
         if self.result.failed:
             # Check for SSH auth errors that should skip the test instead of failing
-            ssh_auth_error = "Error getting one time auth code: Error getting SSH code: Error requesting one time code from server:"
-            
+            ssh_auth_error = (
+                "Error getting one time auth code: Error getting SSH code: Error requesting one time code from server:"
+            )
+
             if ssh_auth_error in self.result.stderr or ssh_auth_error in self.result.stdout:
                 import pytest
+
                 pytest.skip(f"Test skipped due to SSH auth error (CF platform issue): {ssh_auth_error}")
-            
+
             raise AssertionError(
                 f"Expected command to succeed, but it failed with code {self.result.returncode}:\n"
                 f"Command: {self.result.command}\n"

test/test_asprof.py

@@ -259,7 +259,7 @@ def test_asprof_collect_multiple_files(self, t, app):
             "cpu.jfr"
         ).should_create_file("alloc.jfr")
 
-    @test
+    @test()
     def test_asprof_keep_remote_files(self, t, app):
         """Test keeping remote files with asprof."""
         # Generate a file and keep it
@@ -281,19 +281,19 @@ def test_asprof_invalid_args_flag_for_non_args_commands(self, t, app):
 class TestAsprofEdgeCases(TestBase):
     """Edge cases and error conditions for async-profiler."""
 
-    @test
+    @test()
     def test_asprof_start_commands_file_flags_validation(self, t, app):
         """Test that asprof-start commands reject inappropriate file flags."""
         # asprof-start commands have GenerateFiles=false, so some file flags should be rejected
         for flag in ["--keep", "--no-download"]:
             t.run(f"asprof-start-cpu {app} {flag}").should_fail().should_contain("not supported for asprof-start-cpu")
 
-    # @test
+    # @test()
     # def test_asprof_stop_requires_prior_start(self, t, app):
     #    """Test asprof-stop behavior when no profiling is active."""
     #    t.run(f"asprof-stop {app}").should_fail().should_contain("[ERROR] Profiler has not started").no_files()
 
-    @test
+    @test()
     def test_asprof_different_event_types(self, t, app):
         """Test CPU event type via asprof command."""
         # Test CPU event type

test/test_cf_java_plugin.py

@@ -21,7 +21,7 @@
 class TestDryRunConsistency(TestBase):
     """Test that all commands support --dry-run consistently."""
 
-    @test
+    @test()
     def test_all_commands_support_dry_run(self, t, app):
         """Test that all major commands support --dry-run flag."""
         commands = [
@@ -49,7 +49,7 @@ def test_all_commands_support_dry_run(self, t, app):
 class TestWorkflows(TestBase):
     """Integration tests for complete workflows."""
 
-    @test
+    @test()
     def test_diagnostic_data_collection_workflow(self, t, app):
         """Test collecting comprehensive diagnostic data."""
         # 1. Collect VM information
@@ -68,7 +68,7 @@ def test_diagnostic_data_collection_workflow(self, t, app):
         # 5. Capture performance data
         t.run(f"jfr-stop {app} --local-dir .").should_succeed().should_create_file(f"{app}-jfr-*.jfr")
 
-    @test
+    @test()
     def test_performance_analysis_workflow(self, t, app):
         """Test performance analysis workflow with async-profiler."""
         # 1. Baseline: Get VM vitals

test/test_jfr.py

@@ -17,14 +17,14 @@
 class TestJFRBasic(TestBase):
     """Basic JFR functionality tests."""
 
-    @test
+    @test()
     def test_status_no_recording(self, t, app):
         """Test JFR status when no recording is active."""
         t.run(f"jfr-status {app}").should_succeed().should_match(
             r"No available recordings\.\s*Use jcmd \d+ JFR\.start to start a recording\."
         ).no_files()
 
-    @test
+    @test()
     def test_status_with_active_recording(self, t, app):
         """Test JFR status shows active recording information."""
         # Start recording
@@ -38,7 +38,7 @@ def test_status_with_active_recording(self, t, app):
             "*.jfr"
         ).should_create_no_files()
 
-    @test
+    @test()
     def test_jfr_dump(self, t, app):
         """Test JFR dump functionality."""
         # Start recording
@@ -57,7 +57,7 @@ def test_jfr_dump(self, t, app):
             "*.jfr"
         ).should_create_no_remote_files()
 
-    @test
+    @test()
     def test_concurrent_recordings_prevention(self, t, app):
         """Test that concurrent JFR recordings are prevented."""
         # Start first recording
@@ -69,13 +69,13 @@ def test_concurrent_recordings_prevention(self, t, app):
         # Clean up - stop the first recording
         t.run(f"jfr-stop {app} --no-download").should_succeed()
 
-    @test
+    @test()
     def test_gc_profile(self, t, app):
         """Test JFR GC profile (SapMachine only)."""
         t.run(f"jfr-start-gc {app}").should_succeed().no_files()
         t.run(f"jfr-stop {app} --no-download").should_succeed().should_create_remote_file("*.jfr")
 
-    @test
+    @test()
     def test_gc_details_profile(self, t, app):
         """Test JFR detailed GC profile (SapMachine only)."""
         t.run(f"jfr-start-gc-details {app}").should_succeed().no_files()