[BUG] Save button inactive after change in Settings -> Modes -> [Mode change]

[PlanBernhard]

Problem (one or two sentences)

The save button is inactive after I switched the mode and when I switch the Mode the API Configuration overrules the newly chosen mode.

Context (who is affected and when)

The whole work process is affected. This is critical. This costs me a lot of money

Reproduction steps

1. Open Settings -> Modes
2. Change the API-Configuration -> Save button is inactive
3. Change the Mode -> API Configuration overrides the original of the newly chosen Mode -> Save button is inactive
4. Change the API Configuration
5. Switch back to the mode you had at the beginning -> API Configuration is overwritten

Expected result

Save button

Actual result

Nothing gets saved and it overwrites critical settings

Variations tried (optional)

No response

App Version

Version: 3.53.0 (44f6bba)

API Provider (optional)

None

Model Used (optional)

No response

Roo Code Task Links (optional)

after change after change after change

Relevant logs or errors (optional)

[roomote-v0]

I've analyzed this issue and here's my understanding and proposed implementation plan:

Root Cause Analysis

The API Configuration dropdown in ModesView (Settings -> Modes tab) sends a loadApiConfiguration message directly to the backend, which applies the change immediately. This has two problems:

1. Save button stays inactive: The Providers tab wraps its API config selector in checkUnsaveChanges() (see SettingsView.tsx line 746), which ensures the user is prompted about unsaved changes before switching profiles. But ModesView's API config selector at line 913-920 of ModesView.tsx bypasses this entirely -- it calls loadApiConfiguration directly. When the backend processes this, it updates currentApiConfigName, which triggers the sync effect in SettingsView.tsx (lines 210-220) that resets cachedState and sets isChangeDetected = false. This means any unsaved settings changes are silently discarded and the Save button resets to inactive.

2. API Configuration bleeds across modes: When the user changes the API config to profile Y on Mode A, activateProviderProfile immediately persists Y as Mode A's config. Then when switching to Mode B, if Mode B has no previously saved config, the backend auto-saves the current config (Y) as Mode B's default (handleModeSwitch in ClineProvider.ts lines 1465-1475). This makes it appear that Y "overrode" Mode B's config.

Proposed Fix

1. Pass checkUnsaveChanges to ModesView from SettingsView

Modify SettingsView.tsx to pass the checkUnsaveChanges callback as a prop to ModesView:

{renderTab === "modes" && <ModesView checkUnsaveChanges={checkUnsaveChanges} />}

2. Wrap ModesView's API config selector in checkUnsaveChanges

In ModesView.tsx, accept the new optional prop and wrap the loadApiConfiguration call:

onValueChange={(value) => {
    const doSwitch = () => vscode.postMessage({
        type: "loadApiConfiguration",
        text: value,
    })
    if (checkUnsaveChanges) {
        checkUnsaveChanges(doSwitch)
    } else {
        doSwitch()
    }
}}

This makes the behavior consistent with the Providers tab -- if there are unsaved changes, the user is prompted to discard them before the API config switch is applied.

3. Do not auto-save current config when switching to a mode without a saved config

In ClineProvider.ts handleModeSwitch(), remove or guard the else branch (lines 1465-1475) that auto-saves the current config as the default for the new mode. This prevents config "bleed" across modes:

} else {
    // Previously: auto-saved current config as new mode default
    // Now: do nothing, let the new mode use whatever config is current
    // without persisting the association
}

This approach would require the user to explicitly set a mode's API config rather than having it implicitly inherited.

Files to Modify

• webview-ui/src/components/settings/SettingsView.tsx -- pass checkUnsaveChanges prop to ModesView
• webview-ui/src/components/modes/ModesView.tsx -- accept prop, wrap API config change in checkUnsaveChanges
• src/core/webview/ClineProvider.ts -- remove auto-save behavior in handleModeSwitch else branch
• Related test files for the above components

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.

[PlanBernhard]

Sorry @roomote I don't know the code base of Roo Code. Some maintainer has to decide this

[roomote-v0]

Thanks @PlanBernhard for the context. I've seen the previous analysis and will proceed with implementing a fix based on the plan outlined above. I'll open a draft PR shortly to share progress -- feedback and guidance from maintainers are welcome.

[roomote-v0]

Opened a draft PR with my attempt at addressing this: #12285. Feedback welcome!