[BUG] Roo wants to read this file but the file is a folder

[RQuintin]

Problem (one or two sentences)

So I have a codebase in folder - let's say located here: ~/codebase

When I open the folder "~/codebase" in vscode or create a workspace for the folder and then use roo code; I get the error below all the time - which blocks flow because I have to manually click the proceed button. I think this is particularly bad with Grok Fast 4.1 Code - not sure if it's model provider specific. I'm on Linux but I can't figure out why roo code wants to read a folder as though it's a file.

Roo wants to edit this file "~/codebase"

Roo is having trouble...
This may indicate a failure in the model's thought process or inability to use a tool properly, which can be mitigated with some user guidance (e.g. "Try breaking down the task into smaller steps").

Context (who is affected and when)

Anytime analysis of the codebase is required.

Reproduction steps

Arch Linux; Code OSS. Version: 1.107.0
Commit: 302ff6a2e235c95b88e587d4a4b6eeb1b6613297
Date: 2025-12-12T19:06:53.864Z
Electron: 39.2.7
ElectronBuildId: undefined
Chromium: 142.0.7444.235
Node.js: 22.21.1
V8: 14.2.231.21-electron.0
OS: Linux x64 6.17.9-arch1-1

Expected result

No need to try to view the project root folder as a file. Maybe a Linux OS thing?

Actual result

Roo does not try to read the project root folder ever, it's a folder not a file. Why try to read it?

Variations tried (optional)

No response

App Version

Version: 3.38.0 (83b7045)

API Provider (optional)

xAI (Grok)

Model Used (optional)

grok-code-fast-1

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

[roomote]

I've analyzed this issue and here's my proposed implementation plan:

Problem Analysis

The bug occurs because when the AI model attempts to read a directory (like the project root ~/codebase), the directory check happens after user approval is requested. This causes:

1. A confusing prompt: "Roo wants to read this file ~/codebase"
2. User must click proceed even though it's invalid
3. Then an error appears explaining it's a directory

Root Cause

In src/core/tools/ReadFileTool.ts, the directory validation at lines 354-366 occurs inside the loop that processes already-approved files, rather than during the initial validation phase (lines 157-207).

Proposed Fix

Move the directory check to the first validation loop (around line 190, after rooIgnore check but before adding to filesToApprove):

1. After checking rooIgnore access and before adding the file to filesToApprove, add:

// Check if the path is a directory before requesting approval
try {
    const stats = await fs.stat(fullPath)
    if (stats.isDirectory()) {
        const errorMsg = `Cannot read '${relPath}' because it is a directory. To view the contents of a directory, use the list_files tool instead.`
        updateFileResult(relPath, {
            status: "blocked",
            error: errorMsg,
            xmlContent: `<file><path>${relPath}</path><error>Error reading file: ${errorMsg}</error></file>`,
            nativeContent: `File: ${relPath}\nError: Error reading file: ${errorMsg}`,
        })
        await task.say("error", `Error reading file ${relPath}: ${errorMsg}`)
        continue
    }
} catch (error) {
    // File may not exist yet - let later validation handle this
}

2. The existing directory check at line 354 can remain as a safety net, but will rarely be triggered.

Benefits

• Users never see the confusing "wants to read this file" message for directories
• Clear error message immediately suggests using list_files instead
• No approval flow interruption for invalid requests
• Model gets feedback faster to correct its behavior

Files to Modify

• src/core/tools/ReadFileTool.ts - Add early directory validation
• Add/update test cases for directory validation

This approach will fix the issue while maintaining backward compatibility and keeping the existing safety checks in place.

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.

[RQuintin]

actually the message is roo wants to edit this file.

There is nothing to edit - it's the workspace root folder. Why edit it let alone read it?

[mrubens]

Does it seem like this is the same issue as #10328?