Skip to content

MAPCO-10412: init sync service#14

Open
RonIsraeli123 wants to merge 11 commits into
masterfrom
feature/MAPCO-10412
Open

MAPCO-10412: init sync service#14
RonIsraeli123 wants to merge 11 commits into
masterfrom
feature/MAPCO-10412

Conversation

@RonIsraeli123
Copy link
Copy Markdown
Owner

Question Answer
Bug fix ✔/✖
New feature ✔/✖
Breaking change ✔/✖
Deprecations ✔/✖
Documentation ✔/✖
Tests added ✔/✖
Chore ✔/✖

Related issues: #XXX , #XXX ...
https://mapcolonies.atlassian.net/browse/MAPCO-10412
Closes #XXX ...

Further information:

@RonIsraeli123 RonIsraeli123 changed the title init sync service MAPCO-10412: init sync service Apr 15, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

🎫 Related Jira Issue: MAPCO-10412

Copy link
Copy Markdown

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 😎

Comment thread src/common/syncConfig.ts Outdated
Comment thread src/index.ts
Comment thread src/index.ts
@@ -17,6 +18,9 @@ void getApp()

server.listen(port, () => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove openAPI if it's not in use. (including irrelvent packages such as "express-openapi-validator", "@map-colonies/openapi-helpers", "@map-colonies/openapi-express-viewer")
  • Please remove the routes, Controllers, Managers from Server builder of "resourceName" and "anotherResource", "jest-openapi",
  • Run audit fix to fix dependencies
  • Update Package.json file ("name", "description", irrelevent openApi scripts)

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread src/scheduler/syncManager.ts Outdated
Comment thread src/scheduler/syncManager.ts Outdated
Comment thread src/scheduler/syncManager.ts
Comment thread src/externalClients/layersClient/layersClient.ts
Copy link
Copy Markdown
Owner Author

@RonIsraeli123 RonIsraeli123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread src/common/syncConfig.ts Outdated
Comment thread src/externalClients/layersClient/layersClient.ts
Comment thread src/scheduler/syncManager.ts Outdated
Comment thread src/scheduler/syncManager.ts Outdated
Comment thread src/scheduler/syncManager.ts
Comment thread src/scheduler/syncManager.ts
Comment thread src/index.ts
Comment thread src/index.ts
@@ -17,6 +18,9 @@ void getApp()

server.listen(port, () => {
Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants