remove master/slave references

[trusktr]

It will be more respectful for all possible users to remove the master / slave terminology from the lib.

rosnodejs/src/lib/RosNode.js

Lines 22 to 23 in af5d458

	let MasterApiClient = require('./MasterApiClient.js');
	let SlaveApiClient = require('./SlaveApiClient.js');

PR with initial replacements: #152. I'm not sure what will break yet.

⬛

[chfritz]

Would it make sense to wait and see how ROS core decides to resolve this issue first? I think it would be very confusing to use different terminology in the ROS libraries than in ROS core.

[trusktr]

I have a feeling it will take more time for ROS core, because it may be a huge breaking change. Do you know if there's interest there?

[chfritz]

No, I haven't spoken with anyone at OSRF lately. I agree though that is could end up being a huge change. It might even require every ROS user to update their code, since the words in question appear in the API itself.

[chris-smith]

I think I'd at least like to hear what ROS thinks. Doing this would break the api and make it harder for new and current users.