new: more validation

Author: ishland

src/main/java/com/ishland/flowsched/scheduler/ItemHolder.java

@@ -345,11 +345,27 @@ void validateCompletedFutures(ItemStatus<K, V, Ctx> current) {
         }
     }
 
+    void validateAllFutures() {
+        synchronized (this) {
+            for (int i = this.unloadedStatus.ordinal() + 1; i < this.futures.length; i++) {
+                CompletableFuture<Void> future = this.futures[i];
+                if (i <= this.getStatus().ordinal()) {
+                    Assertions.assertTrue(future.isDone(), "Future for loaded status must be completed");
+                }
+                if (i <= this.getTargetStatus().ordinal()) {
+                    Assertions.assertTrue(future != UNLOADED_FUTURE, "Future for requested status cannot be UNLOADED_FUTURE");
+                } else {
+                    Assertions.assertTrue(future == UNLOADED_FUTURE, "Future for non-requested status must be UNLOADED_FUTURE");
+                }
+            }
+        }
+    }
+
     void validateRequestedFutures(ItemStatus<K, V, Ctx> current) {
         synchronized (this) {
             for (int i = this.unloadedStatus.ordinal() + 1; i <= current.ordinal(); i++) {
                 CompletableFuture<Void> future = this.futures[i];
-                Assertions.assertTrue(future != UNLOADED_FUTURE, "Future for loaded status cannot be UNLOADED_FUTURE");
+                Assertions.assertTrue(future != UNLOADED_FUTURE, "Future for requested status cannot be UNLOADED_FUTURE");
             }
         }
     }

src/main/java/com/ishland/flowsched/scheduler/StatusAdvancingScheduler.java

@@ -113,7 +113,7 @@ void tickHolder0(ItemHolder<K, V, Ctx, UserData> holder) {
 //        holder.sanitizeSetStatus = null;
             if (nextStatus == current) {
                 holder.flushUnloadedStatus(current);
-                holder.validateCompletedFutures(current);
+                holder.validateAllFutures();
                 if (current.equals(getUnloadedStatus())) {
                     if (holder.isDependencyDirty()) {
                         holder.executeCriticalSectionAndBusy(() -> holder.cleanupDependencies(this));