Bug: Fails to add another patch source.

[kelvinkad]

Bug description

Attempting to add an additional patch source leads to an error that renders all existing patch sources, including the ReVanced patches, unusable. Understanding that unofficial patches are not supported, I am prompted to ask: why is the functionality to add additional patch sources from a link or file present?

Version of ReVanced Manager and version & name of app you are patching

revanced-manager-1.26.0-dev.9

Installation method

None

ReVanced Manager logs

java.lang.NoSuchMethodError: No static method getResourceGroup(Ljava/util/List;[Ljava/lang/String;)Ljava/util/List; in class Lapp/revanced/util/ResourceUtilsKt; or its super classes (declaration of 'app.revanced.util.ResourceUtilsKt' appears in /data/user/0/app.revanced.manager/app_patch_bundles/0/patches.jar)
	at app.revanced.patches.music.layout.branding.icon.CustomBrandingIconPatchKt.<clinit>(CustomBrandingIconPatch.kt:88)
	at java.lang.reflect.Method.invoke(Native Method)
	at app.revanced.patcher.patch.PatchLoader$Companion.getPatchMethods(Unknown Source:93)
	at app.revanced.patcher.patch.PatchLoader$Companion.loadPatches$lambda$7$lambda$5(Unknown Source:15)
	at app.revanced.patcher.patch.PatchLoader$Companion.$r8$lambda$UPT495uAurdGuuLRzO753_XL_XA(Unknown Source:0)
	at app.revanced.patcher.patch.PatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:67)
	at kotlin.sequences.FlatteningSequence$iterator$1.ensureItemIterator(Unknown Source:40)
	at kotlin.sequences.FlatteningSequence$iterator$1.hasNext(Unknown Source:11)
	at kotlin.sequences.FilteringSequence$iterator$1.calcNext(Unknown Source:2)
	at kotlin.sequences.FilteringSequence$iterator$1.hasNext(Unknown Source:5)
	at kotlin.sequences.SequencesKt___SequencesKt.toSet(Unknown Source:43)
	at app.revanced.patcher.patch.PatchLoader$Companion.loadPatches(Unknown Source:80)
	at app.revanced.patcher.patch.PatchLoader$Companion.access$loadPatches(Unknown Source:0)
	at app.revanced.patcher.patch.PatchLoader.<init>(SourceFile:12)
	at app.revanced.patcher.patch.PatchLoader.<init>(SourceFile:2)
	at app.revanced.patcher.patch.PatchLoader$Dex.<init>(SourceFile:8)
	at app.revanced.patcher.patch.PatchKt.loadPatchesFromDex(Unknown Source:7)
	at app.revanced.patcher.patch.PatchKt.loadPatchesFromDex$default(Unknown Source:5)
	at app.revanced.manager.patcher.patch.PatchBundle$Loader.patches(SourceFile:27)
	at app.revanced.manager.patcher.patch.PatchBundle$Loader.metadata(Unknown Source:5)
	at app.revanced.manager.domain.repository.PatchBundleRepository.loadMetadata(Unknown Source:117)
	at app.revanced.manager.domain.repository.PatchBundleRepository.access$doReload(Unknown Source:295)
	at app.revanced.manager.domain.repository.PatchBundleRepository$doReload$1.invokeSuspend(Unknown Source:11)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:11)
	at kotlinx.coroutines.DispatchedTask.run(Unknown Source:132)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(Unknown Source:95)

Patch logs

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.
• All requested information has been provided properly.
• The bug is only related to ReVanced Manager.

[Axelen123]

Adding other patch sources is an officially supported feature, but we do not officially support the third party patches themselves.
If third party patches are broken and fail to load, thats an issue with them and not manager. By the error message, I am guessing the third party patches are copying classes from the official patches, so you should open an issue there.

Load failures causing all patches to fail is not ideal behavior, and it will be fixed in the future.