bug: About screen does not show app version

[trmdi]

Screenshots of microG Settings' UI:

[oSumAtrIX]

That's not an issue caused by ReVanced. Looks like your device

[trmdi]

My device doesn't do anything specially to block microG to display its version. There must be something wrong in the code. 🤷‍♂️

[oSumAtrIX]

If you think so report the issue to upstream.

[trmdi]

Forgot to say, those are screenshots of microG setting UI, not screenshots of my device's App manager.

[oSumAtrIX]

I understand the issue now. This may be caused by the change in the version for the fork

[trmdi]

I also want to suggest that the About page, or somewhere, should indicate that this is the Revanced fork of microG.

[Amyziya]

Resolve my request

[Myint12thu12]

no log

[er13]

@oSumAtrIX

The problem here is that the (prefix of the) package name in this fork is changed from com.google to app.revanced, the (automatically generated) class BuildConfig is however still gets generated in the original namespace starting with com.google.

The reflection call from this line fails => no version is shown.

Solution alternative 1:
One might adjust the build system to get BuildConfig generated in the right namespace (that starting with app.revanced) and... adjust all lines like import com.google...BuildConfig all over the code.

Solution alternative 2:
The following hack (not tested, just from reading the code) might be a simpler solution to minimize the number of changes to upstream.

--- a/play-services-core/microg-ui-tools/src/main/java/org/microg/tools/ui/AbstractAboutFragment.java
+++ b/play-services-core/microg-ui-tools/src/main/java/org/microg/tools/ui/AbstractAboutFragment.java
@@ -66,7 +66,7 @@ public abstract class AbstractAboutFragment extends Fragment {
 
     public static String getLibVersion(String packageName) {
         try {
-            String versionName = (String) Class.forName(packageName + ".BuildConfig").getField("VERSION_NAME").get(null);
+            String versionName = (String) Class.forName(packageName.replace("app.revanced", "com.google") + ".BuildConfig").getField("VERSION_NAME").get(null);
             if (TextUtils.isEmpty(versionName)) return "";
             return versionName.trim();
         } catch (Exception e) {

This would report the original upstream version. If you want to see "revanced" somewhere, then you'd need to add it in the appropriate place, e.g. by changing return versionName.trim(); to return versionName.trim() + " (ReVanced)";

[oSumAtrIX]

Both work yes, right now its a minor issue and one less change thats needed from upstream so i didnt bother looking into this minor issue over other important stuff yet