added source/value wiping for type change

Author: alexhroom

RATapi/models.py

@@ -96,6 +96,15 @@ def warn_parameters(self):
 
         return self
 
+    def __setattr__(self, name, value):
+        if name == "type":
+            for attr in ["source", "value_1", "value_2", "value_3", "value_4", "value_5"]:
+                with warnings.catch_warnings():
+                    warnings.simplefilter("ignore")
+                    super().__setattr__(attr, "")
+
+        super().__setattr__(name, value)
+
 
 class Contrast(RATModel):
     """A group of all of the components of a model.
@@ -592,3 +601,12 @@ def warn_parameters(self):
             )
 
         return self
+
+    def __setattr__(self, name, value):
+        if name == "type":
+            for attr in ["source", "value_1", "value_2", "value_3", "value_4", "value_5"]:
+                with warnings.catch_warnings():
+                    warnings.simplefilter("ignore")
+                    super().__setattr__(attr, "")
+
+        super().__setattr__(name, value)

tests/test_models.py

@@ -332,3 +332,23 @@ def test_contrast_bad_ratio():
         ),
     ):
         RATapi.models.Contrast(name="My Contrast", domain_ratio="bad ratio")
+
+
+@pytest.mark.parametrize("model", [RATapi.models.Background, RATapi.models.Resolution])
+def test_type_change_clear(model):
+    """If the type of a background or resolution is changed, it should wipe the other fields."""
+
+    model_instance = model(
+        name="Test",
+        type="constant",
+        source="src",
+        value_1="val1",
+        value_2="val2",
+        value_3="val3",
+        value_4="val4",
+        value_5="val5",
+    )
+
+    model_instance.type = "data"
+    for attr in ["source", "value_1", "value_2", "value_3", "value_4", "value_5"]:
+        assert getattr(model_instance, attr) == ""