Skip to content

Commit d26e760

Browse files
authored
Bug fix for dummy value for qzshifts in "inputs.py" (#31)
* Updates README.md * Bug fix in dummy value for "contrastQzshifts"
1 parent 494ddfd commit d26e760

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

RAT/inputs.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,14 +118,14 @@ def make_problem(project: RAT.Project) -> ProblemDefinition:
118118
problem.params = [param.value for param in project.parameters]
119119
problem.bulkIn = [param.value for param in project.bulk_in]
120120
problem.bulkOut = [param.value for param in project.bulk_out]
121-
problem.qzshifts = []
121+
problem.qzshifts = [0.0]
122122
problem.scalefactors = [param.value for param in project.scalefactors]
123123
problem.domainRatio = [param.value for param in project.domain_ratios]
124124
problem.backgroundParams = [param.value for param in project.background_parameters]
125125
problem.resolutionParams = [param.value for param in project.resolution_parameters]
126126
problem.contrastBulkIns = [project.bulk_in.index(contrast.bulk_in, True) for contrast in project.contrasts]
127127
problem.contrastBulkOuts = [project.bulk_out.index(contrast.bulk_out, True) for contrast in project.contrasts]
128-
problem.contrastQzshifts = [1] * len(project.contrasts) # This is marked as "to do" in RAT
128+
problem.contrastQzshifts = [0] * len(project.contrasts) # This is marked as "to do" in RAT
129129
problem.contrastScalefactors = [project.scalefactors.index(contrast.scalefactor, True) for contrast in project.contrasts]
130130
problem.contrastDomainRatios = [project.domain_ratios.index(contrast.domain_ratio, True)
131131
if hasattr(contrast, 'domain_ratio') else 0 for contrast in project.contrasts]

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,14 @@ To install in local directory:
99
pip install -e .
1010

1111
matlabengine is an optional dependency only required for Matlab custom functions. The version of matlabengine should match the version of Matlab installed on the machine. This can be installed as shown below:
12+
1213
pip install -e .[Matlab-2023a]
1314

14-
Development dependencies can be installed as shown below
15+
Development dependencies can be installed as shown below
16+
1517
pip install -e .[Dev]
1618

1719
To build wheel:
20+
1821
pip install build
1922
python -m build --wheel

0 commit comments

Comments
 (0)