Skip to content

Commit 1f1133c

Browse files
committed
Shortened regex
1 parent 0a66c7d commit 1f1133c

5 files changed

Lines changed: 14 additions & 14 deletions

File tree

models/User.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ module.exports = {
1616
'2.0', '3.0', '3.5', '4.0', '4.5', '5.0', '5.5', '5.75', '6.0',
1717
'7.0', '8.0', '9.0', '9.5', '10.0', '11.0', '12.0'];
1818
return new Promise((resolve, reject) => {
19-
if (data.username.match(/^[a-zA-Z0-9]{1,20}$/)) {
19+
if (data.username.match(/^[A-z0-9]{1,20}$/)) {
2020
if (data.password === '') {
2121
reject({flash: 'Please provide a password!', redirect: '/register'});
2222

routes/ajax.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ router.get('/snippetLookup/:ref?/:version?', (req, res, next) => {
2525
let version = req.params.version;
2626

2727
Version.getVersion(ref, version).then(ver => {
28-
if (ver === null) {
28+
if (ver === null || ver.published === 0) {
2929
return res.redirect(baseURL + '/');
3030
}
3131

routes/edit.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ router.post('/api/:ref', (req, res, next) => {
7979
} else {
8080
let name = req.body.rename;
8181
if (name === undefined || name === "") name = doc.name;
82-
if (name.match(/^[a-zA-Z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/) === null) {
82+
if (name.match(/^[A-z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/) === null) {
8383
req.flash('warning', 'Only 32 chars max please! Accepted chars: a-Z0-9 _-.+[]{}()');
8484
res.redirect(baseURL + '/edit/api/' + req.params.ref);
8585
} else {
@@ -132,7 +132,7 @@ router.post('/list/:ref', (req, res, next) => {
132132
} else {
133133
let name = req.body.rename;
134134
if (name === undefined || name === "") name = doc.name;
135-
if (name.match(/^[a-zA-Z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/) === null) {
135+
if (name.match(/^[A-z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/) === null) {
136136
req.flash('warning', 'Only 32 chars max please! Accepted chars: a-Z0-9 _-.+[]{}()');
137137
res.redirect(baseURL + '/view/api/' + req.params.ref);
138138
} else if (req.file === undefined) {
@@ -222,7 +222,7 @@ router.post('/snippet/:ref?/:version?', (req, res, next) => {
222222
}
223223

224224
let tags = _.uniq(req.body.tags.split(',').map(tag => tag.trim()).filter(tag => tag !== ""));
225-
let rejects = tags.filter(tag => tag.match(/^([a-zA-Z0-9 _\-\.+\[\]\{\}\(\)]{1,32})$/g) === null);
225+
let rejects = tags.filter(tag => tag.match(/^([A-z0-9 _\-\.+\[\]\{\}\(\)]{1,32})$/g) === null);
226226

227227
Snippet.getCond({ref}).then(doc => {
228228
if (doc.owner !== req.session.user.id) {
@@ -238,7 +238,7 @@ router.post('/snippet/:ref?/:version?', (req, res, next) => {
238238
req.flash('warning', 'Names can\'t be changed for Published Snippets');
239239
res.redirect(`${baseURL}/edit/snippet/${ref}${versionFmt}`);
240240

241-
} else if (name.match(/^[a-zA-Z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/) === null) {
241+
} else if (name.match(/^[A-z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/) === null) {
242242
req.flash('warning', 'Only 32 chars max please! Accepted chars: a-Z0-9 _-.+[]{}()');
243243
res.redirect(`${baseURL}/edit/snippet/${ref}${versionFmt}`);
244244

routes/new.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ router.post('/api', (req, res, next) => {
6969
req.flash('warning', 'Please provide a name for your API');
7070
res.redirect(baseURL + '/new/api');
7171

72-
} else if (!req.body.name.match(/^[a-zA-Z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/)) {
72+
} else if (!req.body.name.match(/^[A-z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/)) {
7373
req.flash('warning', 'Only 32 chars max please! Accepted chars: a-Z0-9 _-.+[]{}()');
7474
res.redirect(baseURL + '/new/api');
7575

@@ -121,7 +121,7 @@ router.post('/list', (req, res, next) => {
121121
}
122122
res.redirect(baseURL + '/new/list');
123123

124-
} else if (!req.body.name.match(/^[a-zA-Z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/)) {
124+
} else if (!req.body.name.match(/^[A-z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/)) {
125125
req.flash('warning', 'Only 32 chars max please! Accepted chars: a-Z0-9 _-.+[]{}()');
126126
res.redirect(baseURL + '/new/list');
127127

@@ -158,14 +158,14 @@ router.post('/snippet', (req, res, next) => {
158158
}
159159

160160
let tags = _.uniq(req.body.tags.split(',').map(tag => tag.trim()).filter(tag => tag !== ""));
161-
let rejects = tags.filter(tag => tag.match(/^([a-zA-Z0-9 _\-\.+\[\]\{\}\(\)]{1,32})$/g) === null);
161+
let rejects = tags.filter(tag => tag.match(/^([A-z0-9 _\-\.+\[\]\{\}\(\)]{1,32})$/g) === null);
162162

163163
if (req.body.name === '') {
164164
req.flash('warning', 'Please provide a name for your Snippet');
165165
res.redirect(baseURL + '/new/snippet');
166166

167167
// Make sure snippet name meets requirements
168-
} else if (!req.body.name.match(/^[a-zA-Z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/)) {
168+
} else if (!req.body.name.match(/^[A-z0-9 _\-\.+\[\]\{\}\(\)]{1,32}$/)) {
169169
req.flash('warning', 'Only 32 chars max please! Accepted chars: a-Z0-9 _-.+[]{}()');
170170
res.redirect(baseURL + '/new/snippet');
171171

src/js/general.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ function snippetDeletePrompt(ref, name) {
9292
}
9393

9494
function updateDates() {
95-
$('.date').each((index, date) => {
96-
$(date).html(moment(new Date($(date).data('date'))/*, "MMDDYYHHmmss"*/).fromNow());
97-
});
98-
}
95+
$('.date').each((index, date) => {
96+
$(date).html(moment(new Date($(date).data('date'))/*, "MMDDYYHHmmss"*/).fromNow());
97+
});
98+
}

0 commit comments

Comments
 (0)