-
Notifications
You must be signed in to change notification settings - Fork 1
Add build instructions, bump SDK version to v143, and add CI/CD #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OSA413
wants to merge
7
commits into
RadiantDerg:main
Choose a base branch
from
OSA413:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
44a2011
Enable dlls for Episode1
OSA413 4bd6622
Other changes that I needed to make it compile on my PC
OSA413 a134430
Add Detours
OSA413 30c0cdd
There's only the x86 version, right?
OSA413 095dcfb
Add CI/CD
OSA413 31c1f7f
Merge remote-tracking branch 'upstream/main'
OSA413 ddf0874
Remove detours from build ci/cd
OSA413 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Build (Windows) | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - "**" | ||
| pull_request: | ||
| branches: | ||
| - "**" | ||
|
|
||
| # Allows you to run this workflow manually from the Actions tab | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: windows-latest | ||
| steps: | ||
| - uses: ilammy/msvc-dev-cmd@v1 | ||
| with: | ||
| arch: x86 | ||
|
|
||
| - uses: actions/checkout@v5 | ||
| with: | ||
| submodules: recursive | ||
|
|
||
| - name: Build AliceModLoader | ||
| run: msbuild /p:Platform=x86 /p:Configuration=Release | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: AliceModLoader | ||
| path: AliceModLoader/bin/Win32/Release/AliceModLoader.dll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # To build | ||
|
|
||
| Note: I haven't figured out how to compile Detours on your local machine, so I took the built binaries from their GitHub. But the instructions should be as follows: | ||
|
|
||
| ```sh | ||
| 1. cd ./dependencies/Detours | ||
| 2. set DETOURS_TARGET_PROCESSOR=x86 | ||
| 3. set DETOURS_CONFIG=Debug #or Release | ||
| 3. nmake | ||
| 4. cd ../.. | ||
| 5. msbuild /p:Platform=x86 | ||
| ``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically this was just compiled directly through Visual Studio, so that should still hold true.
Also, I did some investigation and found that my repositories are missing the binaries detours requires... not sure if I did that intentionally or not. I'll address that soon by linking in my DLLShared repository as a submodule.
Might be a good idea to hold off including build instructions, at least in this PR. Those can be added once there's a finalized solution.