CarbonAssimilation

[runck014]

Calculation of intercellular CO2 has both the compute_Ci and the fixed 70% of ambient.

In the original version the Intercellular_CO2 isn't commented out, but is then overwritten by this fixed approach. See line 409 in original_for_comparison.py and line 93 in carbon_assimilation.py

[DRWang3]

Correct - it's overwritten by fixed approach. I didn't comment out Sajad's original computation of intercellular CO2 when I was testing the fixed approach.

I see you commented out the original approach - that should be fine and not lead any issues. And since the original versus refactored assimilation simulated values look like a good match, I don't think the issues stem from CarbonAssimilation

[runck014]

From a science standpoint, I personally don't have an issue assuming a fixed constant if we agree that it's reasonable and on-average correct. I don't have a good intuition or empirical grounding though to know how wrong the fixed constant might be. Thoughts?