Fix code review issues: consistent logging, Base64 validation, extract magic numbers

Co-authored-by: coopernetes <57812123+coopernetes@users.noreply.github.com>

Author: Copilot

jgit-proxy-core/src/main/java/org/finos/gitproxy/git/LocalRepositoryCache.java

@@ -20,14 +20,16 @@
 @Slf4j
 public class LocalRepositoryCache {
 
+    private static final int DEFAULT_CLONE_DEPTH = 100;
+
     private final Path cacheDirectory;
     private final Map<String, CachedRepository> cache = new ConcurrentHashMap<>();
     private final int cloneDepth;
     private final boolean registerShutdownHook;
 
     /** Default constructor that uses system temp directory with shutdown hook. */
     public LocalRepositoryCache() throws IOException {
-        this(Files.createTempDirectory("jgit-proxy-cache-"), 100, true);
+        this(Files.createTempDirectory("jgit-proxy-cache-"), DEFAULT_CLONE_DEPTH, true);
     }
 
     /**
@@ -37,7 +39,7 @@ public LocalRepositoryCache() throws IOException {
      * @param registerShutdownHook Whether to register shutdown hook (false for Spring apps)
      */
     public LocalRepositoryCache(Path cacheDirectory, boolean registerShutdownHook) throws IOException {
-        this(cacheDirectory, 100, registerShutdownHook);
+        this(cacheDirectory, DEFAULT_CLONE_DEPTH, registerShutdownHook);
     }
 
     /**

jgit-proxy-core/src/main/java/org/finos/gitproxy/git/TemporaryRepositoryResolver.java

@@ -52,11 +52,17 @@ private String extractRemoteUrl(HttpServletRequest req, String name) {
         String authCredentials = "";
 
         if (authHeader != null && authHeader.startsWith("Basic ")) {
-            // Extract credentials from Basic auth
-            String base64Credentials = authHeader.substring("Basic ".length()).trim();
-            String credentials = new String(java.util.Base64.getDecoder().decode(base64Credentials));
-            // credentials format is "username:password"
-            authCredentials = credentials + "@";
+            try {
+                // Extract credentials from Basic auth
+                String base64Credentials =
+                        authHeader.substring("Basic ".length()).trim();
+                String credentials = new String(java.util.Base64.getDecoder().decode(base64Credentials));
+                // credentials format is "username:password"
+                authCredentials = credentials + "@";
+            } catch (IllegalArgumentException e) {
+                log.warn("Invalid Base64 encoding in Authorization header", e);
+                // Continue without auth credentials
+            }
         }
 
         // This is a simplified implementation

jgit-proxy-core/src/main/java/org/finos/gitproxy/servlet/filter/CheckUserPushPermissionFilter.java

@@ -30,7 +30,7 @@ public CheckUserPushPermissionFilter(UserAuthorizationService userAuthorizationS
     public void doHttpFilter(HttpServletRequest request, HttpServletResponse response) throws IOException {
         var requestDetails = (GitRequestDetails) request.getAttribute(GIT_REQUEST_ATTRIBUTE);
         if (requestDetails == null) {
-            log.warn("GitRequestDetails not found in request details");
+            log.warn("GitRequestDetails not found in request attributes");
             return;
         }