Skip to content

Commit bccd965

Browse files
committed
fix: test failures due to changes in push/validation ctx
1 parent 3981b29 commit bccd965

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

jgit-proxy-core/src/test/java/org/finos/gitproxy/git/AuthorEmailValidationHookTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,11 @@ void invalidEmail_recordsFailStep() throws Exception {
156156

157157
hook.onPreReceive(rp, List.of(newBranchCommand(badCommit)));
158158

159-
assertFalse(pushCtx.getSteps().isEmpty());
160-
assertEquals(StepStatus.FAIL, pushCtx.getSteps().get(0).getStatus(), "Invalid email must record FAIL step");
159+
assertFalse(ctx.getIssues().isEmpty());
160+
assertEquals(
161+
"Illegal author email: dev@badomain.io",
162+
ctx.getIssues().get(0).summary(),
163+
"Invalid email must record FAIL step");
161164
}
162165

163166
@Test

jgit-proxy-core/src/test/java/org/finos/gitproxy/git/CommitMessageValidationHookTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,11 @@ void blockedMessage_recordsFailStep() throws Exception {
192192

193193
hook.onPreReceive(rp, List.of(newBranchCommand(wip)));
194194

195-
assertFalse(pushCtx.getSteps().isEmpty());
196-
assertEquals(StepStatus.FAIL, pushCtx.getSteps().get(0).getStatus());
195+
assertFalse(ctx.getIssues().isEmpty());
196+
assertEquals(
197+
"Message: WIP: blocked",
198+
ctx.getIssues().get(0).detail(),
199+
"Invalid commit message must record FAIL step");
197200
}
198201

199202
@Test

0 commit comments

Comments
 (0)