fix: respect NO_COLOR and GITPROXY_NO_EMOJI in all proxy output

ForwardingPostReceiveHook was using raw ANSI concatenation (CYAN +, GREEN
+, RED +) instead of color(), so NO_COLOR had no effect on forwarding
output. It and several servlet filters also called .emoji() directly
instead of sym(), bypassing the GITPROXY_NO_EMOJI check entirely.

Additionally, SymbolCodes.plain() was appending the Unicode text-variation
selector (U+FE0E) which many terminals ignore, still rendering emoji.
Replace with real ASCII fallbacks (!! ok ! x * ->) so no-emoji mode
produces genuinely text-only output.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: coopernetes

jgit-proxy-core/src/main/java/org/finos/gitproxy/git/ForwardingPostReceiveHook.java

@@ -2,6 +2,8 @@
 
 import static org.finos.gitproxy.git.GitClientUtils.AnsiColor.*;
 import static org.finos.gitproxy.git.GitClientUtils.SymbolCodes.*;
+import static org.finos.gitproxy.git.GitClientUtils.color;
+import static org.finos.gitproxy.git.GitClientUtils.sym;
 
 import java.util.ArrayList;
 import java.util.Collection;
@@ -50,8 +52,7 @@ public void onPostReceive(ReceivePack rp, Collection<ReceiveCommand> commands) {
         String upstreamUrl = repo.getConfig().getString("gitproxy", null, "upstreamUrl");
 
         if (upstreamUrl == null) {
-            rp.sendMessage(
-                    RED + "" + NO_ENTRY.emoji() + "  ERROR - no upstream URL configured, cannot forward" + RESET);
+            rp.sendMessage(color(RED, sym(NO_ENTRY) + "  ERROR - no upstream URL configured, cannot forward"));
             log.error("No gitproxy.upstreamUrl in repo config for {}", repo.getDirectory());
             pushContext.addStep(PushStep.builder()
                     .stepName("forward")
@@ -62,7 +63,7 @@ public void onPostReceive(ReceivePack rp, Collection<ReceiveCommand> commands) {
             return;
         }
 
-        rp.sendMessage(CYAN + "" + LINK.emoji() + "  Forwarding to " + upstreamUrl + "..." + RESET);
+        rp.sendMessage(color(CYAN, sym(LINK) + "  Forwarding to " + upstreamUrl + "..."));
 
         List<String> logs = new ArrayList<>();
         logs.add("Forwarding to " + upstreamUrl);
@@ -73,7 +74,7 @@ public void onPostReceive(ReceivePack rp, Collection<ReceiveCommand> commands) {
             URIish upstream = new URIish(upstreamUrl);
             forwardFailed = pushToUpstream(rp, repo, upstream, accepted, logs);
         } catch (Exception e) {
-            rp.sendMessage(RED + "" + CROSS_MARK.emoji() + "  ERROR forwarding to upstream: " + e.getMessage() + RESET);
+            rp.sendMessage(color(RED, sym(CROSS_MARK) + "  ERROR forwarding to upstream: " + e.getMessage()));
             log.error("Failed to push to upstream {}", upstreamUrl, e);
             logs.add("ERROR: " + e.getMessage());
             forwardFailed = true;
@@ -101,7 +102,7 @@ private boolean pushToUpstream(
 
             List<RemoteRefUpdate> updates = buildRefUpdates(repo, commands);
 
-            rp.sendMessage(CYAN + "  Pushing " + updates.size() + " ref(s) to upstream..." + RESET);
+            rp.sendMessage(color(CYAN, "  Pushing " + updates.size() + " ref(s) to upstream..."));
 
             PushResult result = transport.push(NullProgressMonitor.INSTANCE, updates);
 
@@ -113,21 +114,23 @@ private boolean pushToUpstream(
                     case OK:
                     case UP_TO_DATE:
                         rp.sendMessage(
-                                GREEN + "  " + HEAVY_CHECK_MARK.emoji() + "  " + remoteName + " -> " + status + RESET);
+                                color(GREEN, "  " + sym(HEAVY_CHECK_MARK) + "  " + remoteName + " -> " + status));
                         logs.add("PASS: " + remoteName + " -> " + status);
                         break;
                     default:
                         String message = update.getMessage();
-                        rp.sendMessage(RED + "  " + CROSS_MARK.emoji() + "  " + remoteName + " -> " + status
-                                + (message != null ? " (" + message + ")" : "") + RESET);
+                        rp.sendMessage(color(
+                                RED,
+                                "  " + sym(CROSS_MARK) + "  " + remoteName + " -> " + status
+                                        + (message != null ? " (" + message + ")" : "")));
                         log.warn("Upstream push ref {} status: {} {}", remoteName, status, message);
                         logs.add("FAIL: " + remoteName + " -> " + status
                                 + (message != null ? " (" + message + ")" : ""));
                         anyFailed = true;
                 }
             }
 
-            rp.sendMessage(GREEN + "" + HEAVY_CHECK_MARK.emoji() + "  Forwarding complete" + RESET);
+            rp.sendMessage(color(GREEN, sym(HEAVY_CHECK_MARK) + "  Forwarding complete"));
         }
         return anyFailed;
     }

jgit-proxy-core/src/main/java/org/finos/gitproxy/git/GitClientUtils.java

@@ -49,34 +49,37 @@ public String toString() {
     public enum SymbolCodes {
         // https://codepoints.net/U+26D4
         // https://emojipedia.org/no-entry#technical
-        NO_ENTRY("\u26D4"),
+        NO_ENTRY("\u26D4", "!!"),
 
         // https://codepoints.net/U+2705
         // https://emojipedia.org/check-mark-button#technical
-        HEAVY_CHECK_MARK("\u2705"),
+        HEAVY_CHECK_MARK("\u2705", "ok"),
 
         // https://codepoints.net/U+26A0
         // https://emojipedia.org/warning#technical
-        WARNING("\u26A0"),
+        WARNING("\u26A0", "!"),
 
         // https://codepoints.net/U+274C
         // https://emojipedia.org/cross-mark#technical
-        CROSS_MARK("\u274C"),
+        CROSS_MARK("\u274C", "x"),
 
         // Created using codepoints & the Character class due to the point values
         // falling outside the Unicode planes' range supported by Java's \\u escape
         // sequence syntax in Strings
 
         // https://codepoints.net/U+1F511
         // https://emojipedia.org/key#technical
-        KEY(Character.toString(0x1F511)),
+        KEY(Character.toString(0x1F511), "*"),
 
         // https://codepoints.net/U+1F517
         // https://emojipedia.org/link#technical
-        LINK(Character.toString(0x1F517));
+        LINK(Character.toString(0x1F517), "->");
 
         private final String value;
 
+        /** ASCII fallback used when {@code GITPROXY_NO_EMOJI} is set. */
+        private final String text;
+
         /**
          * Returns the emoji representation of the symbol by appending the Unicode variation selector character. This is
          * used to ensure that the symbol is displayed as an emoji in clients that support it.
@@ -88,13 +91,13 @@ public String emoji() {
         }
 
         /**
-         * Returns the plain text representation of the symbol by appending the Unicode variation selector character.
-         * This is used to ensure that the symbol is displayed as plain text in clients that don't support emojis.
+         * Returns the plain ASCII text representation of the symbol. Used when {@code GITPROXY_NO_EMOJI} is set to
+         * avoid terminals that ignore the Unicode text-variation selector (U+FE0E) still rendering emoji.
          *
          * @return the plain text representation of the symbol
          */
         public String plain() {
-            return value + "\uFE0E";
+            return text;
         }
 
         @Override

jgit-proxy-core/src/main/java/org/finos/gitproxy/servlet/filter/CheckEmptyBranchFilter.java

@@ -2,6 +2,7 @@
 
 import static org.finos.gitproxy.git.GitClientUtils.AnsiColor.*;
 import static org.finos.gitproxy.git.GitClientUtils.SymbolCodes.*;
+import static org.finos.gitproxy.git.GitClientUtils.sym;
 import static org.finos.gitproxy.servlet.GitProxyServlet.GIT_REQUEST_ATTR;
 
 import jakarta.servlet.http.HttpServletRequest;
@@ -61,10 +62,10 @@ public void doHttpFilter(HttpServletRequest request, HttpServletResponse respons
         String title;
         String message;
         if (isNewBranch) {
-            title = NO_ENTRY.emoji() + "  Push Blocked — Empty Branch";
+            title = sym(NO_ENTRY) + "  Push Blocked — Empty Branch";
             message = "Please make a commit before pushing a new branch.";
         } else {
-            title = NO_ENTRY.emoji() + "  Push Blocked — Commit Data Not Found";
+            title = sym(NO_ENTRY) + "  Push Blocked — Commit Data Not Found";
             message = "Commit data not found. Please contact an administrator for support.";
         }
 

jgit-proxy-core/src/main/java/org/finos/gitproxy/servlet/filter/CheckHiddenCommitsFilter.java

@@ -2,6 +2,7 @@
 
 import static org.finos.gitproxy.git.GitClientUtils.AnsiColor.*;
 import static org.finos.gitproxy.git.GitClientUtils.SymbolCodes.*;
+import static org.finos.gitproxy.git.GitClientUtils.sym;
 import static org.finos.gitproxy.servlet.GitProxyServlet.GIT_REQUEST_ATTR;
 
 import jakarta.servlet.http.HttpServletRequest;
@@ -95,7 +96,7 @@ public void doHttpFilter(HttpServletRequest request, HttpServletResponse respons
 
             log.warn("checkHiddenCommits: {} hidden commit(s) detected: {}", hidden.size(), hidden);
 
-            String title = NO_ENTRY.emoji() + "  Push Blocked — Hidden Commits Detected";
+            String title = sym(NO_ENTRY) + "  Push Blocked — Hidden Commits Detected";
             String message = "Unreferenced commits in pack (" + hidden.size() + "): "
                     + String.join(", ", hidden) + ".\n\n"
                     + "This usually happens when a branch was made from a commit that hasn't been approved"

jgit-proxy-core/src/main/java/org/finos/gitproxy/servlet/filter/CheckUserPushPermissionFilter.java

@@ -2,6 +2,7 @@
 
 import static org.finos.gitproxy.git.GitClientUtils.AnsiColor.*;
 import static org.finos.gitproxy.git.GitClientUtils.SymbolCodes.*;
+import static org.finos.gitproxy.git.GitClientUtils.sym;
 import static org.finos.gitproxy.servlet.GitProxyServlet.GIT_REQUEST_ATTR;
 
 import jakarta.servlet.http.HttpServletRequest;
@@ -66,7 +67,7 @@ public void doHttpFilter(HttpServletRequest request, HttpServletResponse respons
 
         if (userEmail == null || userEmail.isEmpty()) {
             log.warn("User email not found in commit author");
-            String title = NO_ENTRY.emoji() + "  Push Blocked — Unknown User";
+            String title = sym(NO_ENTRY) + "  Push Blocked — Unknown User";
             String message = "Could not identify the pushing user.\n" + "\n" + "Contact an administrator for support.";
             rejectAndSendError(request, response, "User not found", GitClientUtils.format(title, message, RED, null));
             return;
@@ -75,8 +76,8 @@ public void doHttpFilter(HttpServletRequest request, HttpServletResponse respons
         // Check if user exists
         if (!userAuthorizationService.userExists(userEmail)) {
             log.warn("User {} does not exist in the system", userEmail);
-            String title = NO_ENTRY.emoji() + "  Push Blocked — User Not Registered";
-            String message = CROSS_MARK.emoji() + "  " + userEmail + " is not registered.\n"
+            String title = sym(NO_ENTRY) + "  Push Blocked — User Not Registered";
+            String message = sym(CROSS_MARK) + "  " + userEmail + " is not registered.\n"
                     + "\n"
                     + "Contact an administrator for support.";
             rejectAndSendError(
@@ -92,9 +93,9 @@ public void doHttpFilter(HttpServletRequest request, HttpServletResponse respons
 
         if (!isAuthorized) {
             log.warn("User {} is not authorized to push to repository {}", userEmail, repositoryUrl);
-            String title = NO_ENTRY.emoji() + "  Push Blocked — Unauthorized";
-            String message = CROSS_MARK.emoji() + "  " + userEmail + " is not allowed to push to:\n" + "   "
-                    + LINK.emoji() + "  " + repositoryUrl;
+            String title = sym(NO_ENTRY) + "  Push Blocked — Unauthorized";
+            String message = sym(CROSS_MARK) + "  " + userEmail + " is not allowed to push to:\n" + "   " + sym(LINK)
+                    + "  " + repositoryUrl;
             rejectAndSendError(
                     request, response, "User not authorized", GitClientUtils.format(title, message, RED, null));
             return;

jgit-proxy-core/src/main/java/org/finos/gitproxy/servlet/filter/ScanDiffFilter.java

@@ -2,6 +2,7 @@
 
 import static org.finos.gitproxy.git.GitClientUtils.AnsiColor.*;
 import static org.finos.gitproxy.git.GitClientUtils.SymbolCodes.*;
+import static org.finos.gitproxy.git.GitClientUtils.sym;
 import static org.finos.gitproxy.servlet.GitProxyServlet.GIT_REQUEST_ATTR;
 
 import jakarta.servlet.http.HttpServletRequest;
@@ -93,9 +94,9 @@ public void doHttpFilter(HttpServletRequest request, HttpServletResponse respons
 
             if (!violations.isEmpty()) {
                 log.warn("Diff scan found {} violation(s)", violations.size());
-                String title = NO_ENTRY.emoji() + "  Push Blocked — Diff Contains Blocked Content";
+                String title = sym(NO_ENTRY) + "  Push Blocked — Diff Contains Blocked Content";
                 String violationList = violations.stream()
-                        .map(v -> CROSS_MARK.emoji() + "  " + v.reason())
+                        .map(v -> sym(CROSS_MARK) + "  " + v.reason())
                         .collect(Collectors.joining("\n"));
                 String message = "Diff content contains blocked patterns:\n\n" + violationList;
                 recordIssue(request, "Diff contains blocked content", GitClientUtils.format(title, message, RED, null));

jgit-proxy-core/src/main/java/org/finos/gitproxy/servlet/filter/WhitelistAggregateFilter.java

@@ -1,5 +1,7 @@
 package org.finos.gitproxy.servlet.filter;
 
+import static org.finos.gitproxy.git.GitClientUtils.SymbolCodes.*;
+import static org.finos.gitproxy.git.GitClientUtils.sym;
 import static org.finos.gitproxy.servlet.filter.WhitelistByUrlFilter.WHITELISTED_BY_ATTRIBUTE;
 
 import jakarta.servlet.http.HttpServletRequest;
@@ -85,8 +87,7 @@ public void doHttpFilter(HttpServletRequest request, HttpServletResponse respons
         } else {
             var operation = determineOperation(request);
             String action = operation == HttpOperation.PUSH ? "Push" : "Fetch";
-            String title =
-                    GitClientUtils.SymbolCodes.NO_ENTRY.emoji() + "  " + action + " Blocked — Repository Not Allowed";
+            String title = sym(NO_ENTRY) + "  " + action + " Blocked — Repository Not Allowed";
             String verb = operation == HttpOperation.PUSH ? "Pushes to" : "Fetches from";
             String message = verb + " this repository are not permitted.\n"
                     + "\n"