fix: use AutoApproveGateway in e2e tests to avoid 30-min approval timeout

Valid pushes were being blocked at the approval gate waiting for human
review, causing e2e tests to time out. Replace UiApprovalGateway with a
test-only AutoApproveGateway that immediately approves and returns so the
store-and-forward pass tests complete without manual intervention.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: coopernetes

jgit-proxy-server/src/test/java/org/finos/gitproxy/e2e/AutoApproveGateway.java

@@ -0,0 +1,35 @@
+package org.finos.gitproxy.e2e;
+
+import java.time.Duration;
+import org.finos.gitproxy.approval.ApprovalGateway;
+import org.finos.gitproxy.approval.ApprovalResult;
+import org.finos.gitproxy.approval.ProgressSender;
+import org.finos.gitproxy.db.PushStore;
+import org.finos.gitproxy.db.model.Attestation;
+
+/**
+ * Test-only {@link ApprovalGateway} that immediately approves every push without waiting for human input. Used in e2e
+ * tests so that valid commits are forwarded without blocking.
+ */
+class AutoApproveGateway implements ApprovalGateway {
+
+    private final PushStore pushStore;
+
+    AutoApproveGateway(PushStore pushStore) {
+        this.pushStore = pushStore;
+    }
+
+    @Override
+    public ApprovalResult waitForApproval(String pushId, ProgressSender progress, Duration timeout) {
+        pushStore.approve(
+                pushId,
+                Attestation.builder()
+                        .pushId(pushId)
+                        .type(Attestation.Type.APPROVAL)
+                        .reviewerUsername("e2e-auto-approver")
+                        .reason("Automatically approved by e2e test fixture")
+                        .automated(true)
+                        .build());
+        return ApprovalResult.APPROVED;
+    }
+}

jgit-proxy-server/src/test/java/org/finos/gitproxy/e2e/JettyProxyFixture.java

@@ -12,7 +12,6 @@
 import org.eclipse.jetty.server.Server;
 import org.eclipse.jetty.server.ServerConnector;
 import org.eclipse.jgit.http.server.GitServlet;
-import org.finos.gitproxy.approval.UiApprovalGateway;
 import org.finos.gitproxy.config.CommitConfig;
 import org.finos.gitproxy.config.GpgConfig;
 import org.finos.gitproxy.db.PushStoreFactory;
@@ -59,7 +58,7 @@ class JettyProxyFixture implements AutoCloseable {
         var resolver = new StoreAndForwardRepositoryResolver(storeForwardCache, provider);
         var gitServlet = new GitServlet();
         gitServlet.setRepositoryResolver(resolver);
-        var approvalGateway = new UiApprovalGateway(pushStore);
+        var approvalGateway = new AutoApproveGateway(pushStore);
         gitServlet.setReceivePackFactory(
                 new StoreAndForwardReceivePackFactory(provider, commitConfig, pushStore, approvalGateway));
         gitServlet.setUploadPackFactory(new StoreAndForwardUploadPackFactory());