feat: add multi-failure test case & reduce redundancy in the ui

Author: coopernetes

jgit-proxy-core/src/main/java/org/finos/gitproxy/git/AuthorEmailValidationHook.java

@@ -72,12 +72,16 @@ public void onPreReceive(ReceivePack rp, Collection<ReceiveCommand> commands) {
             }
         }
 
-        pushContext.addStep(PushStep.builder()
-                .stepName("checkAuthorEmails")
-                .status(anyFailed ? StepStatus.FAIL : StepStatus.PASS)
-                .blockedMessage(anyFailed ? "One or more author emails failed validation" : null)
-                .logs(logs)
-                .build());
+        // Only add a summary step when passing — failures are already captured as per-issue
+        // steps by ValidationContext and stored by validationResultHook, so a summary FAIL
+        // step here would duplicate those entries in the UI.
+        if (!anyFailed) {
+            pushContext.addStep(PushStep.builder()
+                    .stepName("checkAuthorEmails")
+                    .status(StepStatus.PASS)
+                    .logs(logs)
+                    .build());
+        }
     }
 
     private List<Commit> getCommits(Repository repo, ReceiveCommand cmd) throws Exception {

jgit-proxy-core/src/main/java/org/finos/gitproxy/git/CommitMessageValidationHook.java

@@ -73,12 +73,16 @@ public void onPreReceive(ReceivePack rp, Collection<ReceiveCommand> commands) {
             }
         }
 
-        pushContext.addStep(PushStep.builder()
-                .stepName("checkCommitMessages")
-                .status(anyFailed ? StepStatus.FAIL : StepStatus.PASS)
-                .blockedMessage(anyFailed ? "One or more commit messages failed validation" : null)
-                .logs(logs)
-                .build());
+        // Only add a summary step when passing — failures are already captured as per-issue
+        // steps by ValidationContext and stored by validationResultHook, so a summary FAIL
+        // step here would duplicate those entries in the UI.
+        if (!anyFailed) {
+            pushContext.addStep(PushStep.builder()
+                    .stepName("checkCommitMessages")
+                    .status(StepStatus.PASS)
+                    .logs(logs)
+                    .build());
+        }
     }
 
     private List<Commit> getCommits(Repository repo, ReceiveCommand cmd) throws Exception {

test-push-fail.sh

@@ -111,6 +111,18 @@ test_token_in_message() {
     git commit -m "chore: rotate token=ghp_abc123def456 in CI config"
 }
 
+# Both email AND message checks fail in the same push — useful for
+# verifying the UI displays multiple simultaneous validation failures.
+test_multi_failure() {
+    # blocked local part (noreply) + non-allowed domain = email fails
+    git config user.name "Noreply Bot"
+    git config user.email "noreply@internal.corp.net"
+    echo "multi failure test - $(date)" >> test-file.txt
+    git add test-file.txt
+    # WIP literal + embedded secret pattern = message fails twice
+    git commit -m "WIP: temp debug, password=hunter2 hardcoded"
+}
+
 # --- Run tests ---
 
 echo "=========================================================="
@@ -130,6 +142,9 @@ run_test "FAIL: DO NOT MERGE message"           fail test_do_not_merge_message
 run_test "FAIL: password in commit message"     fail test_secret_in_message
 run_test "FAIL: token in commit message"        fail test_token_in_message
 
+# Multi-check failure
+run_test "FAIL: blocked email + WIP + secret in message (multi-check)" fail test_multi_failure
+
 echo ""
 echo "=========================================================="
 echo "  RESULTS: ${PASS} passed, ${FAIL} unexpected"