Skip to content

Commit 16c37a0

Browse files
coopernetesclaude
andcommitted
test: fix broken assertions after default provider and URL changes
- Replace bitbucket provider checks with codeberg/gitea (bitbucket was removed from default config in favour of codeberg + gitea) - Update proxy e2e link assertion from /#/push/ to /push/ (changed in the push list/detail UI overhaul) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 49a1188 commit 16c37a0

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

jgit-proxy-server/src/test/java/org/finos/gitproxy/e2e/ProxyModeE2ETest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ private void pushApproveAndVerify(String dirSuffix, String authorEmail, String c
9494
// First push - should be blocked pending review
9595
var firstPush = git.pushWithResult(repo);
9696
assertFalse(firstPush.succeeded(), "first push should be blocked pending review");
97-
assertTrue(firstPush.output().contains("/#/push/"), "should contain link to push record");
97+
assertTrue(firstPush.output().contains("/push/"), "should contain link to push record");
9898

9999
String pushId = firstPush.extractPushId();
100100
assertNotNull(pushId, "push ID should be present in blocked message");

jgit-proxy-server/src/test/java/org/finos/gitproxy/jetty/config/GitProxyConfigLoaderTest.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,13 @@ void defaultProviders_includesGitLab() throws GestaltException {
5555
}
5656

5757
@Test
58-
void defaultProviders_includesBitbucket() throws GestaltException {
59-
assertTrue(GitProxyConfigLoader.load().getProviders().containsKey("bitbucket"));
58+
void defaultProviders_includesCodeberg() throws GestaltException {
59+
assertTrue(GitProxyConfigLoader.load().getProviders().containsKey("codeberg"));
60+
}
61+
62+
@Test
63+
void defaultProviders_includesGitea() throws GestaltException {
64+
assertTrue(GitProxyConfigLoader.load().getProviders().containsKey("gitea"));
6065
}
6166

6267
@Test
@@ -72,7 +77,8 @@ void deepMerge_localOverride_doesNotWipeOtherProviders() throws GestaltException
7277
var providers = GitProxyConfigLoader.load().getProviders();
7378
assertTrue(providers.containsKey("github"));
7479
assertTrue(providers.containsKey("gitlab"));
75-
assertTrue(providers.containsKey("bitbucket"));
80+
assertTrue(providers.containsKey("codeberg"));
81+
assertTrue(providers.containsKey("gitea"));
7682
}
7783

7884
// --- commit config presence ---

0 commit comments

Comments
 (0)