ServiceConnect v7: clean-architecture rewrite — DI-first, async-first, STJ-on-the-wire, operator-grade telemetry

.github/workflows/ci.yml

@@ -0,0 +1,136 @@
+name: CI
+
+on:
+  push:
+    branches: [master, 'v*']
+  pull_request:
+    branches: [master, 'v*']
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+# A new push to a PR / branch cancels the previous in-flight run for the same ref.
+# Saves CI minutes during rapid iteration; the most recent commit is the one that matters.
+concurrency:
+  group: ci-${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+env:
+  DOTNET_NOLOGO: true
+  DOTNET_CLI_TELEMETRY_OPTOUT: 1
+  DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
+  # Deterministic CI builds — combined with the SourceLink + ContinuousIntegrationBuild
+  # properties set in src/Directory.Build.props, ensures the produced binaries embed
+  # repo-relative source paths and are byte-reproducible.
+  ContinuousIntegrationBuild: true
+
+jobs:
+  build-and-test:
+    name: Build + unit tests (${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: |
+            8.0.x
+            10.0.x
+
+      - name: Restore
+        working-directory: src
+        run: dotnet restore ServiceConnect.slnx
+
+      - name: Build
+        working-directory: src
+        run: dotnet build ServiceConnect.slnx --configuration Release --no-restore
+
+      - name: Unit tests
+        working-directory: src
+        run: dotnet test ServiceConnect.UnitTests/ServiceConnect.UnitTests.csproj --configuration Release --no-build --logger "trx;LogFileName=unittests.trx"
+
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: unit-test-results-${{ matrix.os }}
+          path: src/**/TestResults/*.trx
+          if-no-files-found: ignore
+
+  e2e:
+    name: End-to-end tests (Linux)
+    runs-on: ubuntu-latest
+    # Testcontainers spins up RabbitMQ + MongoDB; needs a working Docker daemon.
+    # ubuntu-latest runners have Docker pre-installed, so no setup step is required.
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: |
+            8.0.x
+            10.0.x
+
+      - name: Restore
+        working-directory: src
+        run: dotnet restore ServiceConnect.slnx
+
+      - name: Build
+        working-directory: src
+        run: dotnet build ServiceConnect.slnx --configuration Release --no-restore
+
+      - name: E2E tests
+        working-directory: src
+        run: dotnet test ServiceConnect.EndToEndTests/ServiceConnect.EndToEndTests.csproj --configuration Release --no-build --logger "trx;LogFileName=e2e.trx"
+
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: e2e-test-results
+          path: src/**/TestResults/*.trx
+          if-no-files-found: ignore
+
+  pack-validate:
+    name: Pack validation (dry-run)
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: |
+            8.0.x
+            10.0.x
+
+      - name: Restore
+        working-directory: src
+        run: dotnet restore ServiceConnect.slnx
+
+      - name: Pack
+        working-directory: src
+        run: dotnet pack ServiceConnect.slnx --configuration Release --no-restore --output ../artifacts
+
+      - name: List produced packages
+        run: ls -la artifacts/
+
+      - name: Upload artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: nupkgs
+          path: |
+            artifacts/*.nupkg
+            artifacts/*.snupkg
+          if-no-files-found: error
+          retention-days: 14

.github/workflows/docs.yml

@@ -0,0 +1,60 @@
+name: Build and deploy docs site
+
+on:
+  push:
+    branches: [v7-clean-architecture]
+    paths:
+      - 'website/**'
+      - '.github/workflows/docs.yml'
+  workflow_dispatch:
+
+permissions:
+  contents: read
+  pages: write
+  id-token: write
+
+concurrency:
+  group: pages
+  cancel-in-progress: false
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '22'
+          cache: 'npm'
+          cache-dependency-path: website/package-lock.json
+
+      - name: Install website dependencies
+        working-directory: website
+        run: npm ci
+
+      - name: Build website (Astro + Starlight)
+        working-directory: website
+        run: npm run build
+
+      - name: Setup Pages
+        uses: actions/configure-pages@v5
+
+      - name: Upload Pages artifact
+        uses: actions/upload-pages-artifact@v3
+        with:
+          path: website/dist
+
+  deploy:
+    needs: build
+    if: github.ref == 'refs/heads/v7-clean-architecture'
+    runs-on: ubuntu-latest
+    environment:
+      name: github-pages
+      url: ${{ steps.deployment.outputs.page_url }}
+    steps:
+      - name: Deploy to GitHub Pages
+        id: deployment
+        uses: actions/deploy-pages@v4

.github/workflows/release.yml

@@ -0,0 +1,118 @@
+name: Release to NuGet
+
+# Triggered on a `v*` tag push (e.g. `v7.0.0`). The tag value drives the package Version
+# property — release the same source tree against a new tag by retagging, not by editing
+# csprojs. The "Verify tag matches Version property" step blocks a mismatched cut.
+
+on:
+  push:
+    tags:
+      - 'v*'
+  workflow_dispatch:
+    inputs:
+      version:
+        description: 'Version override (without leading v). Used only for manual dispatch; tag pushes use the tag value.'
+        required: false
+
+permissions:
+  contents: read
+
+env:
+  DOTNET_NOLOGO: true
+  DOTNET_CLI_TELEMETRY_OPTOUT: 1
+  DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
+  ContinuousIntegrationBuild: true
+
+jobs:
+  release:
+    name: Pack + push
+    runs-on: ubuntu-latest
+    environment:
+      name: nuget
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: |
+            8.0.x
+            10.0.x
+
+      - name: Resolve version from tag
+        id: version
+        run: |
+          if [ -n "${{ inputs.version }}" ]; then
+            VERSION="${{ inputs.version }}"
+          else
+            # github.ref is "refs/tags/v7.0.0"; strip the prefix.
+            VERSION="${GITHUB_REF#refs/tags/v}"
+          fi
+          echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+          echo "Resolved version: $VERSION"
+
+      - name: Verify tag matches csproj Version property
+        working-directory: src
+        run: |
+          set -e
+          DECLARED=$(grep -oP '<Version>\K[^<]+' Directory.Build.props | head -1)
+          if [ "$DECLARED" != "${{ steps.version.outputs.version }}" ]; then
+            echo "ERROR: Tag version '${{ steps.version.outputs.version }}' does not match Directory.Build.props <Version> '$DECLARED'."
+            echo "Bump src/Directory.Build.props and retag, or correct the tag."
+            exit 1
+          fi
+
+      - name: Restore
+        working-directory: src
+        run: dotnet restore ServiceConnect.slnx
+
+      - name: Build
+        working-directory: src
+        run: dotnet build ServiceConnect.slnx --configuration Release --no-restore -p:Version=${{ steps.version.outputs.version }}
+
+      # Re-run the full test suite against the exact tagged commit before pushing to NuGet.org.
+      # CI already gates merges to master, but a tag can point at any commit and NuGet packages
+      # cannot be unpublished — only delisted — so a green test run here is the last line of defence.
+      - name: Unit tests
+        working-directory: src
+        run: dotnet test ServiceConnect.UnitTests/ServiceConnect.UnitTests.csproj --configuration Release --no-build --logger "trx;LogFileName=unittests.trx"
+
+      - name: E2E tests
+        working-directory: src
+        run: dotnet test ServiceConnect.EndToEndTests/ServiceConnect.EndToEndTests.csproj --configuration Release --no-build --logger "trx;LogFileName=e2e.trx"
+
+      - name: Upload test results
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: release-test-results-${{ steps.version.outputs.version }}
+          path: src/**/TestResults/*.trx
+          if-no-files-found: ignore
+          retention-days: 90
+
+      - name: Pack
+        working-directory: src
+        run: dotnet pack ServiceConnect.slnx --configuration Release --no-build -p:Version=${{ steps.version.outputs.version }} --output ../artifacts
+
+      - name: List produced packages
+        run: ls -la artifacts/
+
+      - name: Upload artifacts (audit trail)
+        uses: actions/upload-artifact@v4
+        with:
+          name: nupkgs-${{ steps.version.outputs.version }}
+          path: |
+            artifacts/*.nupkg
+            artifacts/*.snupkg
+          if-no-files-found: error
+          retention-days: 90
+
+      - name: Push to NuGet.org
+        # --skip-duplicate so a re-run after a partial failure doesn't error on packages
+        # already pushed; NuGet.org treats a re-push of the same version as a conflict.
+        run: |
+          dotnet nuget push 'artifacts/*.nupkg' \
+            --api-key "${{ secrets.NUGET_API_KEY }}" \
+            --source https://api.nuget.org/v3/index.json \
+            --skip-duplicate

.gitignore

@@ -18,6 +18,7 @@ bld/
 
 # Visual Studio 2015/2017 cache/options directory
 .vs/
+.vscode/
 
 # MSTest test Results
 [Tt]est[Rr]esult*/
@@ -175,3 +176,30 @@ UpgradeLog*.htm
 
 # Microsoft Fakes
 FakesAssemblies/
+.gitnexus
+.worktrees/
+
+# Claude Code settings
+AGENTS.md
+CLAUDE.md
+.claude/
+
+# Documentation site (Astro/Starlight)
+website/dist/
+website/.astro/
+
+# Brainstorming companion artifacts
+.superpowers/
+
+# Test runner output
+**/TestResults/
+*.trx
+
+# Stress harness report output (regenerated on every run)
+out/
+**/out/
+
+# Working specs / plans authored during agent sessions (committed deliberately,
+# not auto-staged from the working tree). Anchored to the repo root so the rule
+# doesn't accidentally match website/src/content/docs/ and trap new doc pages.
+/docs/