debug CI

Author: ianthomas23

src/utils/credentials.cpp

@@ -32,7 +32,7 @@ int user_credentials(
 
         std::string password = prompt_input("Password: ", false);
 
-        std::cout << "YYYY password " << username.size() << " " << " YYYY" << std::endl;
+        std::cout << "YYYY password " << password.size() << " " << " YYYY" << std::endl;
 
         if (password.empty()) {
             giterr_set_str(GIT_ERROR_HTTP, "No password specified");

test/test_clone.py

@@ -55,8 +55,14 @@ def test_clone_private_repo(git2cpp_path, tmp_path, run_in_tmp_path, private_tes
     repo_path = tmp_path / private_test_repo['repo_name']
     url = private_test_repo['https_url' if protocol == 'https' else 'http_url']
 
-    clone_cmd = [git2cpp_path.str(), "clone", url]
-    p_clone = subprocess.run(" ".join(clone_cmd), capture_output=True, text=True, input=input, shell=True)
+    clone_cmd = [git2cpp_path, "clone", url]
+    #p_clone = subprocess.run(clone_cmd, capture_output=True, text=True, input=input)
+    p_clone = subprocess.Popen(clone_cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE,
+                               stderr=subprocess.PIPE, text=True)
+    p_clone.stdout, p_clone.stderr = p_clone.communicate(input)
+
+
+
     assert p_clone.returncode == 0
     assert repo_path.exists()
     # Single request for username and password.
@@ -79,8 +85,8 @@ def test_clone_private_repo_fails_then_succeeds(
     input = "\n".join(["wrong1", "wrong2", username, password])
     repo_path = tmp_path / private_test_repo['repo_name']
 
-    clone_cmd = [git2cpp_path.str(), "clone", private_test_repo['https_url']]
-    p_clone = subprocess.run(" ".join(clone_cmd), capture_output=True, text=True, input=input, shell=True)
+    clone_cmd = [git2cpp_path, "clone", private_test_repo['https_url']]
+    p_clone = subprocess.run(clone_cmd, capture_output=True, text=True, input=input)
     assert p_clone.returncode == 0
     assert repo_path.exists()
     # Two requests for username and password.
@@ -100,8 +106,8 @@ def test_clone_private_repo_fails_on_no_username(
     input = ""
     repo_path = tmp_path / private_test_repo['repo_name']
 
-    clone_cmd = [git2cpp_path.str(), "clone", private_test_repo['https_url']]
-    p_clone = subprocess.run(" ".join(clone_cmd), capture_output=True, text=True, input=input, shell=True)
+    clone_cmd = [git2cpp_path, "clone", private_test_repo['https_url']]
+    p_clone = subprocess.run(clone_cmd, capture_output=True, text=True, input=input)
 
     assert p_clone.returncode != 0
     assert "No username specified" in p_clone.stderr
@@ -116,8 +122,8 @@ def test_clone_private_repo_fails_on_no_password(
     input = "username\n"  # Note no password after the \n
     repo_path = tmp_path / private_test_repo['repo_name']
 
-    clone_cmd = [git2cpp_path.str(), "clone", private_test_repo['https_url']]
-    p_clone = subprocess.run(" ".join(clone_cmd), capture_output=True, text=True, input=input, shell=True)
+    clone_cmd = [git2cpp_path, "clone", private_test_repo['https_url']]
+    p_clone = subprocess.run(clone_cmd, capture_output=True, text=True, input=input)
 
     assert p_clone.returncode != 0
     assert "No password specified" in p_clone.stderr