address review cooment

Author: SandrineP

src/subcommand/log_subcommand.cpp

@@ -230,7 +230,9 @@ void log_subcommand::print_commit(repository_wrapper& repo, const commit_wrapper
 
     std::string message = commit.message();
     while (!message.empty() && message.back() == '\n')
+    {
         message.pop_back();
+    }
 
     if (oneline)
     {

src/subcommand/revparse_subcommand.cpp

@@ -8,10 +8,9 @@ revparse_subcommand::revparse_subcommand(const libgit2_object&, CLI::App& app)
 
     auto* bare_opt = sub->add_flag("--is-bare-repository", m_is_bare_repository_flag, "When the repository is bare print \"true\", otherwise \"false\".");
     auto* shallow_opt = sub->add_flag("--is-shallow-repository", m_is_shallow_repository_flag, "When the repository is shallow print \"true\", otherwise \"false\".");
+    auto* rev_opt = sub->add_option("<rev>", m_revisions, "Revision(s) to parse (e.g. HEAD, main, HEAD~1, dae86e, ...)");
 
-    sub->add_option("<rev>", m_revisions, "Revision(s) to parse (e.g. HEAD, main, HEAD~1, dae86e, ...)");
-
-    sub->parse_complete_callback([this, sub, bare_opt, shallow_opt]() {
+    sub->parse_complete_callback([this, sub, bare_opt, shallow_opt, rev_opt]() {
         for (CLI::Option* opt : sub->parse_order())
         {
             if (opt == bare_opt)
@@ -22,6 +21,10 @@ revparse_subcommand::revparse_subcommand(const libgit2_object&, CLI::App& app)
             {
                 m_queries_in_order.push_back("is_shallow");
             }
+            else if (opt == rev_opt)
+            {
+                m_queries_in_order.push_back("is_rev");
+            }
         }
     });
 
@@ -45,27 +48,26 @@ void revparse_subcommand::run()
             {
                 std::cout << std::boolalpha << repo.is_shallow() << std::endl;
             }
-        }
-        return;
-    }
+            if (q == "is_rev")
+            {
+                for (const auto& rev : m_revisions)
+                {
+                    auto obj = repo.revparse_single(rev.c_str());
 
-    if (!m_revisions.empty())
-    {
-        for (const auto& rev : m_revisions)
-        {
-            auto obj = repo.revparse_single(rev.c_str());
+                    if (!obj.has_value())
+                    {
+                        throw git_exception("bad revision '" + rev + "'", git2cpp_error_code::BAD_ARGUMENT);
+                    }
 
-            if (!obj.has_value())
-            {
-                throw git_exception("bad revision '" + rev + "'", git2cpp_error_code::BAD_ARGUMENT);
-                return;
+                    auto oid = obj.value().oid();
+                    std::cout << git_oid_tostr_s(&oid) << std::endl;
+                }
             }
-
-            auto oid = obj.value().oid();
-            std::cout << git_oid_tostr_s(&oid) << std::endl;
         }
-        return;
     }
-
-    std::cout << "revparse only supports --is-bare-repository, --is-shallow-repository and parsing revisions for now" << std::endl;
+    else
+    {
+        std::cout << "revparse only supports --is-bare-repository, --is-shallow-repository and parsing revisions for now" << std::endl;
+    }
+    return;
 }