Axios 0.28 on Stage breaks dataset search.

[adam3smith]

Due to axios/axios#4734
the requests to the mydata Dataverse API on stage include [] in the publicationStatus terms, so
published_states[]=Published&published_states[]=Unpublished&published_states[]=Draft&published_states[]=In+Review
instead of the correct
published_states=Published&published_states=Unpublished&published_states=Draft&published_states=In%20Review

This breaks all dataset searches, both for ATI projects and for projects to turn into ATI projects

[adam3smith]

Comment from Jim:

Sounds good. He may have tried to fix it with

AnnoREP-Frontend/pages/api/mydata-search.ts

Line 44 in 87824fc

return qs.stringify(params, { indices: false })

- not sure if it needs a different spelling as suggested by axios/axios#1443 (comment).

[tohuynh]

The upgrade to axios version must have made qs.stringify(params, { indices: false }) no longer removes []s. I'll try to take a look at the issue sometime this weekend if it's not urgent.

[adam3smith]

Not urgent -- production still is on 0.21 and works -- thanks!

…

Sent from my phone

On Wed, Jul 17, 2024, 21:36 To Huynh ***@***.***> wrote: The upgrade to axios version must have made qs.stringify(params, { indices: false }) no longer removes []s. I'll try to take a look at the issue sometime this weekend if it's not urgent. — Reply to this email directly, view it on GitHub <#176 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA7PWTMBYFGVLLRAOGI4Z3ZM4LYPAVCNFSM6AAAAABK7LPFJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZVGA2TQMBZG4> . You are receiving this because you authored the thread.Message ID: ***@***.*** com>

[tohuynh]

It looks like 0.28.0 made breaking changes and paramsSerializer can longer be a function. The fix is supposedly in 0.28.1, I'll see if that fixes it.

[qqmyers]

With #177 merged, should this issue close?