Skip to content

Commit 224fd62

Browse files
fassko2ndalpha
authored andcommitted
Fixes #43 (#44)
* Fixes #43 User can be optional when editing ticket * Fixes #43 User ID is optional. * Fixes #43 Fix scr and tests.
1 parent df5745c commit 224fd62

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "qminder-api",
3-
"version": "0.1.27",
3+
"version": "0.1.28",
44
"description": "Qminder API",
55
"homepage": "http://www.qminderapp.com",
66
"license": "Apache-2.0",

src/qminder-api.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -316,11 +316,11 @@ var Qminder = (function() {
316316
assertNotNull(id, ERRORS.TICKET);
317317
assertNotNull(parameters, ERRORS.PARAMETERS);
318318
assertTrue(typeof parameters == "object", ERRORS.PARAMETEROBJECT);
319-
assertNotNull(user, ERRORS.USER);
320319
assertNotNull(callback, ERRORS.CALLBACK);
321320

322-
var data = "user=" + user;
323-
var validParameters = ["phoneNumber", "firstName", "lastName", "extra"];
321+
var data = "";
322+
323+
var validParameters = ["user", "phoneNumber", "firstName", "lastName", "extra"];
324324

325325
for (var key in parameters) {
326326
if (!parameters.hasOwnProperty(key)) {

test/tickets-spec.js

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -552,17 +552,7 @@ describe("Tickets", function() {
552552

553553
expect(call).toThrow("Parameters not provided");
554554
});
555-
556-
// http://qminderapp.com/docs/api/tickets/#editing
557-
it("should throw exception for missing user id in editing call", function() {
558-
559-
var call = function() {
560-
Qminder.tickets.edit(1, {});
561-
};
562555

563-
expect(call).toThrow("User ID not provided");
564-
});
565-
566556
// http://qminderapp.com/docs/api/tickets/#editing
567557
it("should throw exception for missing callback function in editing call", function() {
568558

@@ -580,7 +570,7 @@ describe("Tickets", function() {
580570
Qminder.tickets.edit(123, {"name": "Tuuli"}, 2, function() {});
581571
};
582572

583-
expect(call).toThrow("Parameter \"name\" is unknown and should not be used. Valid parameters: [\"phoneNumber\",\"firstName\",\"lastName\",\"extra\"]");
573+
expect(call).toThrow("Parameter \"name\" is unknown and should not be used. Valid parameters: [\"user\",\"phoneNumber\",\"firstName\",\"lastName\",\"extra\"]");
584574
});
585575

586576

0 commit comments

Comments
 (0)