fix: parse_time_to_datetime method

Author: humbertogontijo

roborock/util.py

@@ -34,10 +34,9 @@ def parse_time_to_datetime(
         hour=end_time.hour, minute=end_time.minute, second=0, microsecond=0
     )
 
-    now = datetime.datetime.now(DEFAULT_TIME_ZONE)
-    if start_datetime > now > end_datetime:
+    if start_datetime > end_datetime:
         end_datetime += datetime.timedelta(days=1)
-    elif end_datetime < now:
+    elif end_datetime < datetime.datetime.now(DEFAULT_TIME_ZONE):
         start_datetime += datetime.timedelta(days=1)
         end_datetime += datetime.timedelta(days=1)
 

tests/test_util.py

@@ -0,0 +1,65 @@
+import datetime
+
+import pytest
+
+from roborock import parse_time_to_datetime
+
+
+@pytest.mark.skip
+def validate(start: datetime.datetime, end: datetime.datetime) -> bool:
+    duration = end - start
+    return duration > datetime.timedelta()
+
+
+# start_date < now < end_date
+def test_start_date_lower_than_end_date_lower_than_now():
+    start, end = parse_time_to_datetime(
+        (datetime.datetime.now() - datetime.timedelta(hours=2)).time(),
+        (datetime.datetime.now() - datetime.timedelta(hours=1)).time(),
+    )
+    assert validate(start, end)
+
+
+# start_date > now > end_date
+def test_start_date_greater_than_now_greater_tat_end_date():
+    start, end = parse_time_to_datetime(
+        (datetime.datetime.now() + datetime.timedelta(hours=1)).time(),
+        (datetime.datetime.now() + datetime.timedelta(hours=2)).time(),
+    )
+    assert validate(start, end)
+
+
+# start_date < now > end_date
+def test_start_date_lower_than_now_greater_than_end_date():
+    start, end = parse_time_to_datetime(
+        (datetime.datetime.now() - datetime.timedelta(hours=1)).time(),
+        (datetime.datetime.now() + datetime.timedelta(hours=1)).time(),
+    )
+    assert validate(start, end)
+
+
+# start_date > now < end_date
+def test_start_date_greater_than_now_lower_than_end_date():
+    start, end = parse_time_to_datetime(
+        (datetime.datetime.now() + datetime.timedelta(hours=1)).time(),
+        (datetime.datetime.now() - datetime.timedelta(hours=1)).time(),
+    )
+    assert validate(start, end)
+
+
+# start_date < end_date < now
+def test_start_date_lower_than_end_date_lower_than_now():
+    start, end = parse_time_to_datetime(
+        (datetime.datetime.now() - datetime.timedelta(hours=2)).time(),
+        (datetime.datetime.now() - datetime.timedelta(hours=1)).time(),
+    )
+    assert validate(start, end)
+
+
+# start_date > end_date > now
+def test_start_date_greater_than_end_date_greater_than_now():
+    start, end = parse_time_to_datetime(
+        (datetime.datetime.now() + datetime.timedelta(hours=2)).time(),
+        (datetime.datetime.now() + datetime.timedelta(hours=1)).time(),
+    )
+    assert validate(start, end)