Skip to content

Commit a63a6c9

Browse files
committed
chore: use the existing device logger
1 parent 11816e4 commit a63a6c9

File tree

5 files changed

+10
-29
lines changed

5 files changed

+10
-29
lines changed

roborock/devices/device.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
from typing import Any, TypeVar, cast
1313

1414
from roborock.data import HomeDataDevice, HomeDataProduct
15-
from roborock.devices.logger import DeviceLoggerAdapter
1615
from roborock.exceptions import RoborockException
1716
from roborock.roborock_message import RoborockMessage
17+
from roborock.util import RoborockLoggerAdapter
1818

1919
from .channel import Channel
2020
from .traits import Trait
@@ -60,7 +60,7 @@ def __init__(
6060
"""
6161
TraitsMixin.__init__(self, trait)
6262
self._duid = device_info.duid
63-
self._logger = DeviceLoggerAdapter(_LOGGER, self._duid)
63+
self._logger = RoborockLoggerAdapter(self._duid, _LOGGER)
6464
self._name = device_info.name
6565
self._device_info = device_info
6666
self._product = product

roborock/devices/local_channel.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@
1111
from roborock.roborock_message import RoborockMessage, RoborockMessageProtocol
1212

1313
from ..protocols.v1_protocol import LocalProtocolVersion
14-
from ..util import get_next_int
14+
from ..util import RoborockLoggerAdapter, get_next_int
1515
from .channel import Channel
16-
from .logger import DeviceLoggerAdapter
1716

1817
_LOGGER = logging.getLogger(__name__)
1918
_PORT = 58867
@@ -55,7 +54,7 @@ class LocalChannel(Channel):
5554

5655
def __init__(self, host: str, local_key: str, device_uid: str) -> None:
5756
self._host = host
58-
self._logger = DeviceLoggerAdapter(_LOGGER, device_uid)
57+
self._logger = RoborockLoggerAdapter(device_uid, _LOGGER)
5958
self._transport: asyncio.Transport | None = None
6059
self._protocol: _LocalProtocol | None = None
6160
self._subscribers: CallbackList[RoborockMessage] = CallbackList(self._logger)

roborock/devices/logger.py

Lines changed: 0 additions & 18 deletions
This file was deleted.

roborock/devices/mqtt_channel.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
from roborock.mqtt.session import MqttParams, MqttSession, MqttSessionException
1010
from roborock.protocol import create_mqtt_decoder, create_mqtt_encoder
1111
from roborock.roborock_message import RoborockMessage
12+
from roborock.util import RoborockLoggerAdapter
1213

1314
from .channel import Channel
14-
from .logger import DeviceLoggerAdapter
1515

1616
_LOGGER = logging.getLogger(__name__)
1717

@@ -26,7 +26,7 @@ class MqttChannel(Channel):
2626
def __init__(self, mqtt_session: MqttSession, duid: str, local_key: str, rriot: RRiot, mqtt_params: MqttParams):
2727
self._mqtt_session = mqtt_session
2828
self._duid = duid
29-
self._logger = DeviceLoggerAdapter(_LOGGER, duid)
29+
self._logger = RoborockLoggerAdapter(duid, _LOGGER)
3030
self._local_key = local_key
3131
self._rriot = rriot
3232
self._mqtt_params = mqtt_params

roborock/devices/v1_channel.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
from typing import Any, TypeVar
1313

1414
from roborock.data import HomeDataDevice, NetworkInfo, RoborockBase, UserData
15-
from roborock.devices.logger import DeviceLoggerAdapter
1615
from roborock.exceptions import RoborockException
1716
from roborock.mqtt.health_manager import HealthManager
1817
from roborock.mqtt.session import MqttParams, MqttSession
@@ -31,6 +30,7 @@
3130
)
3231
from roborock.roborock_message import RoborockMessage, RoborockMessageProtocol
3332
from roborock.roborock_typing import RoborockCommand
33+
from roborock.util import RoborockLoggerAdapter
3434

3535
from .cache import DeviceCache
3636
from .channel import Channel
@@ -71,7 +71,7 @@ class RpcStrategy:
7171
class RpcChannel(V1RpcChannel):
7272
"""Provides an RPC interface around a pub/sub transport channel."""
7373

74-
def __init__(self, rpc_strategies_cb: Callable[[], list[RpcStrategy]], logger: DeviceLoggerAdapter) -> None:
74+
def __init__(self, rpc_strategies_cb: Callable[[], list[RpcStrategy]], logger: RoborockLoggerAdapter) -> None:
7575
"""Initialize the RpcChannel with an ordered list of strategies."""
7676
self._rpc_strategies_cb = rpc_strategies_cb
7777
self._logger = logger
@@ -110,7 +110,7 @@ async def send_command(
110110

111111
@staticmethod
112112
async def _send_rpc(
113-
strategy: RpcStrategy, request: RequestMessage, logger: DeviceLoggerAdapter
113+
strategy: RpcStrategy, request: RequestMessage, logger: RoborockLoggerAdapter
114114
) -> ResponseData | bytes:
115115
"""Send a command and return a decoded response type.
116116
@@ -178,7 +178,7 @@ def __init__(
178178
) -> None:
179179
"""Initialize the V1Channel."""
180180
self._device_uid = device_uid
181-
self._logger = DeviceLoggerAdapter(_LOGGER, device_uid)
181+
self._logger = RoborockLoggerAdapter(device_uid, _LOGGER)
182182
self._security_data = security_data
183183
self._mqtt_channel = mqtt_channel
184184
self._mqtt_health_manager = HealthManager(self._mqtt_channel.restart)

0 commit comments

Comments
 (0)