Skip to content

Commit 7a2b8e2

Browse files
committed
chore: remove pending rpcs object
1 parent 5d78df1 commit 7a2b8e2

File tree

4 files changed

+3
-126
lines changed

4 files changed

+3
-126
lines changed

roborock/devices/a01_channel.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,9 @@ async def send_decoded_command(
5454
await mqtt_channel.publish(roborock_message)
5555
return {}
5656

57-
# This can be simplified if we can assume a all results are returned in
58-
# single response. Otherwise, this will construct a result by merging in
59-
# responses that contain the ids that were queried.
57+
# Merge any results together than contain the requested data. This
58+
# does not use a future since it needs to merge results across responses.
59+
# This could be simplified if we can assume there is a single response.
6060
finished = asyncio.Event()
6161
result: dict[int, Any] = {}
6262

roborock/devices/mqtt_channel.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
from roborock.roborock_message import RoborockMessage
1111

1212
from .channel import Channel
13-
from .pending import PendingRpcs
1413

1514
_LOGGER = logging.getLogger(__name__)
1615

@@ -29,8 +28,6 @@ def __init__(self, mqtt_session: MqttSession, duid: str, local_key: str, rriot:
2928
self._rriot = rriot
3029
self._mqtt_params = mqtt_params
3130

32-
# RPC support
33-
self._pending_rpcs: PendingRpcs[int, RoborockMessage] = PendingRpcs()
3431
self._decoder = create_mqtt_decoder(local_key)
3532
self._encoder = create_mqtt_encoder(local_key)
3633
self._mqtt_unsub: Callable[[], None] | None = None

roborock/devices/pending.py

Lines changed: 0 additions & 45 deletions
This file was deleted.

tests/devices/test_pending.py

Lines changed: 0 additions & 75 deletions
This file was deleted.

0 commit comments

Comments
 (0)