Skip to content

Commit 795482c

Browse files
committed
Remove unnecessary refactor changes
1 parent df36aa0 commit 795482c

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

roborock/web_api.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import string
1010
import time
1111
from dataclasses import dataclass
12-
from typing import List
1312

1413
import aiohttp
1514
from aiohttp import ContentTypeError, FormData
@@ -75,7 +74,7 @@ def __init__(
7574
self._device_identifier = secrets.token_urlsafe(16)
7675
self.session = session
7776
self._iot_login_info: IotLoginInfo | None = None
78-
self._base_urls: List[str] = BASE_URLS if base_url is None else [base_url]
77+
self._base_urls = BASE_URLS if base_url is None else [base_url]
7978

8079
async def _get_iot_login_info(self) -> IotLoginInfo:
8180
if self._iot_login_info is None:
@@ -271,9 +270,9 @@ async def request_code_v4(self) -> None:
271270
elif response_code == 9002:
272271
raise RoborockTooFrequentCodeRequests("You have attempted to request too many codes. Try again later")
273272
elif response_code == 3030 and len(self._base_urls) > 1:
274-
self._base_urls = self._base_urls[1:]
275-
self._iot_login_info = None
276-
return await self.request_code_v4()
273+
self._base_urls = self._base_urls[1:]
274+
self._iot_login_info = None
275+
return await self.request_code_v4()
277276
else:
278277
raise RoborockException(f"{code_response.get('msg')} - response code: {code_response.get('code')}")
279278

tests/test_web_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,14 @@ async def test_url_cycling(mock_rest) -> None:
9292
# Clear mock rest so that we can override the patches.
9393
mock_rest.clear()
9494

95-
# 2. Mock US URL to return valid status but None for countrycode
95+
# 1. Mock US URL to return valid status but None for countrycode
9696
mock_rest.post(
9797
re.compile("https://usiot.roborock.com/api/v1/getUrlByEmail.*"),
9898
status=200,
9999
payload={
100100
"code": 200,
101101
"data": {"url": "https://usiot.roborock.com", "country": None, "countrycode": None},
102-
"msg": "Account in deletion",
102+
"msg": "Success",
103103
},
104104
)
105105

0 commit comments

Comments
 (0)