fix: Encode a01 values as json strings

Update the a01 internal values to be json strings inside the dictionary. This matches the old API behavior.

Author: allenporter

roborock/protocols/a01_protocol.py

@@ -26,7 +26,10 @@ def encode_mqtt_payload(
     | dict[RoborockDyadDataProtocol | RoborockZeoProtocol, Any],
 ) -> RoborockMessage:
     """Encode payload for A01 commands over MQTT."""
-    dps_data = {"dps": data}
+    # The A01 protocol generally expects values to be encoded as strings.
+    # We use json.dumps for non-string types to ensure valid JSON formatting
+    # (e.g. [1, 2] -> "[1, 2]", True -> "true", 123 -> "123").
+    dps_data = {"dps": {key: json.dumps(value) for key, value in data.items()}}
     payload = pad(json.dumps(dps_data).encode("utf-8"), AES.block_size)
     return RoborockMessage(
         protocol=RoborockMessageProtocol.RPC_REQUEST,

tests/protocols/test_a01_protocol.py

@@ -4,6 +4,8 @@
 from typing import Any
 
 import pytest
+from Crypto.Cipher import AES
+from Crypto.Util.Padding import unpad
 
 from roborock.exceptions import RoborockException
 from roborock.protocols.a01_protocol import decode_rpc_response, encode_mqtt_payload
@@ -33,8 +35,9 @@ def test_encode_mqtt_payload_basic():
     assert len(result.payload) % 16 == 0  # Should be padded to AES block size
 
     # Decode the payload to verify structure
+    # With general stringification, numbers are converted to strings: 42 -> "42"
     decoded_data = decode_rpc_response(result)
-    assert decoded_data == {200: {"test": "data", "number": 42}}
+    assert decoded_data == {200: '{"test": "data", "number": 42}'}
 
 
 def test_encode_mqtt_payload_empty_data():
@@ -52,6 +55,21 @@ def test_encode_mqtt_payload_empty_data():
     assert decoded_data == {}
 
 
+def test_encode_mqtt_payload_list_conversion():
+    """Test that lists are converted to string representation (Fix validity)."""
+    # This verifies the fix where lists must be encoded as strings
+    data: dict[RoborockDyadDataProtocol | RoborockZeoProtocol, Any] = {RoborockDyadDataProtocol.ID_QUERY: [101, 102]}
+
+    result = encode_mqtt_payload(data)
+
+    # Decode manually to check the raw JSON structure
+    decoded_json = json.loads(unpad(result.payload, AES.block_size).decode())
+
+    # ID_QUERY (10000) should be a string "[101, 102]", not a list [101, 102]
+    assert decoded_json["dps"]["10000"] == "[101, 102]"
+    assert isinstance(decoded_json["dps"]["10000"], str)
+
+
 def test_encode_mqtt_payload_complex_data():
     """Test encoding with complex nested data."""
     data: dict[RoborockDyadDataProtocol | RoborockZeoProtocol, Any] = {
@@ -74,13 +92,17 @@ def test_encode_mqtt_payload_complex_data():
     # Decode the payload to verify structure
     decoded_data = decode_rpc_response(result)
     assert decoded_data == {
-        201: {
-            "nested": {"deep": {"value": 123}},
-            "list": [1, 2, 3, "test"],
-            "boolean": True,
-            "null": None,
-        },
-        204: "simple_value",
+        201: json.dumps(
+            {
+                "nested": {"deep": {"value": 123}},
+                # Note: The list inside the dictionary is NOT converted because
+                # our fix only targets top-level list values in the dps map
+                "list": [1, 2, 3, "test"],
+                "boolean": True,
+                "null": None,
+            }
+        ),
+        204: '"simple_value"',
     }