chore: Enable verbose logging in CI

Author: allenporter

.github/workflows/ci.yml

@@ -50,7 +50,7 @@ jobs:
         run: poetry install
         shell: bash
       - name: Test with Pytest
-        run: poetry run pytest
+        run: poetry run pytest --log-level=DEBUG -vv -s
         shell: bash
   release:
     runs-on: ubuntu-latest

tests/devices/test_mqtt_channel.py

@@ -2,6 +2,7 @@
 
 import asyncio
 import json
+import logging
 from collections.abc import Callable, Generator
 from unittest.mock import AsyncMock, Mock, patch
 
@@ -82,6 +83,15 @@ async def setup_message_handler(mqtt_session: Mock, mqtt_channel: MqttChannel) -
     return message_handler
 
 
+@pytest.fixture
+def warning_caplog(
+    caplog: pytest.LogCaptureFixture,
+) -> Generator[pytest.LogCaptureFixture]:
+    """Fixture to capture warning messages."""
+    caplog.set_level(logging.WARNING)
+    yield caplog
+
+
 async def home_home_data_no_devices() -> HomeData:
     """Mock home data API that returns no devices."""
     return HomeData(
@@ -163,7 +173,7 @@ async def test_concurrent_commands(
     mqtt_session: Mock,
     mqtt_channel: MqttChannel,
     mqtt_message_handler: Callable[[bytes], None],
-    caplog: pytest.LogCaptureFixture,
+    warning_caplog: pytest.LogCaptureFixture,
 ) -> None:
     """Test handling multiple concurrent RPC commands."""
 
@@ -187,7 +197,7 @@ async def test_concurrent_commands(
     assert result1 == TEST_RESPONSE
     assert result2 == TEST_RESPONSE2
 
-    assert not caplog.records
+    assert not warning_caplog.records
 
 
 async def test_concurrent_commands_same_request_id(

tests/test_api.py

@@ -142,7 +142,11 @@ async def connected_mqtt_client_fixture(
     response_queue.put(mqtt_packet.gen_suback(1, 0))
     await mqtt_client.async_connect()
     yield mqtt_client
-
+    if mqtt_client.is_connected():
+        try:
+            await mqtt_client.async_disconnect()
+        except Exception:
+            pass
 
 async def test_async_connect(received_requests: Queue, connected_mqtt_client: RoborockMqttClientV1) -> None:
     """Test connecting to the MQTT broker."""
@@ -173,6 +177,28 @@ async def test_connect_failure_response(
     assert received_requests.qsize() == 1  # Connect attempt
 
 
+async def test_disconnect_already_disconnected(connected_mqtt_client: RoborockMqttClientV1) -> None:
+    """Test the MQTT client error handling for a no-op disconnect."""
+
+    assert connected_mqtt_client.is_connected()
+
+    # Make the MQTT client simulate returning that it already thinks it is disconnected
+    with patch("roborock.cloud_api.mqtt.Client.disconnect", return_value=mqtt.MQTT_ERR_NO_CONN):
+        await connected_mqtt_client.async_disconnect()
+
+
+async def test_disconnect_failure(connected_mqtt_client: RoborockMqttClientV1) -> None:
+    """Test that the MQTT client ignores  MQTT client error handling for a no-op disconnect."""
+
+    assert connected_mqtt_client.is_connected()
+
+    # Make the MQTT client returns with an error when disconnecting
+    with patch("roborock.cloud_api.mqtt.Client.disconnect", return_value=mqtt.MQTT_ERR_PROTOCOL), pytest.raises(
+        RoborockException, match="Failed to disconnect"
+    ):
+        await connected_mqtt_client.async_disconnect()
+
+
 async def test_disconnect_failure_response(
     received_requests: Queue,
     response_queue: Queue,