fix(app): ignore finalized ssh startup failures

Author: skulidropek

packages/app/src/web/actions-project-terminal.ts

@@ -174,15 +174,16 @@ const showPendingTerminalError = (
   context: BrowserActionContext,
   runtime: ConnectProjectRuntime,
   error: string
-): void => {
+): boolean => {
   const wasFinalized = runtime.pendingSessionFinalized
   if (wasFinalized) {
-    return
+    return false
   }
   runtime.pendingSessionFinalized = true
   runtime.lifecycle.onFailure?.(error)
   appendOutputLine(context, `[error] ${error}`)
   context.addTerminalSession(renderPendingTerminalSession(context, runtime, error, "error"))
+  return true
 }
 
 const attachCreatedSession = (
@@ -225,8 +226,9 @@ const handleProjectEvent = (
 ): void => {
   const failure = readTerminalStartupFailure(event, requestId)
   if (failure !== null) {
-    showPendingTerminalError(context, runtime, failure)
-    context.setMessage(failure)
+    if (showPendingTerminalError(context, runtime, failure)) {
+      context.setMessage(failure)
+    }
     closeStream(runtime)
     return
   }

packages/app/tests/docker-git/actions-project-terminal-lifecycle.test.ts

@@ -228,13 +228,17 @@ describe("project terminal connect lifecycle", () => {
       const pendingSessionId = "00000000-0000-4000-8000-000000000006"
       loadProjectTerminalSessionMock.mockImplementation(() => Effect.succeed({ ...session, id: pendingSessionId }))
       const addTerminalSession = vi.fn<(session: ActiveTerminalSession) => void>()
-      const { context, lifecycle } = prepareAcceptedConnect(pendingSessionId, { addTerminalSession })
+      const { context, lifecycle, setMessage } = prepareAcceptedConnect(pendingSessionId, { addTerminalSession })
 
       yield* _(connectAndAttachSession(context, lifecycle, pendingSessionId))
       emitStartupFailure(pendingSessionId, "Late backend failure.")
 
       expect(lifecycle.onFailure).not.toHaveBeenCalled()
       expect(addTerminalSession).toHaveBeenCalledTimes(2)
+      expect(setMessage).not.toHaveBeenCalledWith("Late backend failure.")
+      expect(setMessage).toHaveBeenLastCalledWith(
+        "Project is ready. SSH terminal is connecting for octocat/hello-world."
+      )
     }))
 
   it.effect("reports failure when startup fails", () =>