fix: satisfy effect lint for create flow

Author: skulidropek

packages/app/src/docker-git/menu-create-shared.ts

@@ -279,7 +279,10 @@ const parseRepoStepInput = (
   })
 }
 
-const createStepApplied = (): Either.Either<true, ParseError> => Either.right(true as const)
+const createStepApplied = (): Either.Either<true, ParseError> => {
+  const applied: true = true
+  return Either.right(applied)
+}
 
 const hasOwn = <K extends keyof CreateInputs>(values: Partial<CreateInputs>, key: K): boolean =>
   Object.prototype.hasOwnProperty.call(values, key)

packages/app/tests/docker-git/app-ready-create.test.ts

@@ -1,25 +1,52 @@
-import type { Dispatch, SetStateAction } from "react"
+import type { SetStateAction } from "react"
 import { describe, expect, it, vi } from "vitest"
 
 import { createInitialFlowView, type CreateFlowView, resolveCreateFlowSteps } from "../../src/docker-git/menu-create-shared.js"
 import type { BrowserActionContext } from "../../src/web/actions.js"
 import { submitCreateView } from "../../src/web/app-ready-create.js"
 
+const createSetter = <A>() => vi.fn((_value: SetStateAction<A>) => undefined)
+
 const createBrowserActionContext = (): BrowserActionContext => ({
+  addTerminalSession: vi.fn(),
+  databaseConnectionInput: "",
+  databaseLabelInput: "",
   githubStatus: {
-    tokens: [{ status: "valid" }]
-  } as never,
+    summary: "ok",
+    tokens: [{ key: "GITHUB_TOKEN", label: "default", login: "octocat", status: "valid" }]
+  },
+  portForwardInput: "",
+  reloadDashboard: vi.fn(),
+  selectedProjectId: null,
+  selectedProjectKey: null,
+  selectedProjectName: null,
   setActionPrompt: vi.fn(),
-  setActiveScreen: vi.fn(),
+  setActiveScreen: createSetter(),
+  setAuthSnapshot: createSetter(),
+  setBusyLabel: createSetter(),
+  setDatabaseConnectionInput: createSetter(),
+  setDatabaseForwards: createSetter(),
+  setDatabaseLabelInput: createSetter(),
+  setDatabaseProfiles: createSetter(),
+  setDatabaseSession: createSetter(),
+  setGithubStatus: createSetter(),
   setMessage: vi.fn(),
-  setSelectedMenuIndex: vi.fn()
-} as unknown as BrowserActionContext)
+  setOutput: createSetter(),
+  setPortForwardInput: createSetter(),
+  setPortForwards: createSetter(),
+  setProjectAuthSnapshot: createSetter(),
+  setProjectBrowser: createSetter(),
+  setProjectTaskLogs: createSetter(),
+  setProjectTasks: createSetter(),
+  setSelectedMenuIndex: createSetter(),
+  setSelectedProject: createSetter(),
+  setSelectedProjectId: createSetter()
+})
 
 describe("app-ready-create", () => {
   it("advances to the next create field on Enter for a repo URL", () => {
     const context = createBrowserActionContext()
-    const setCreateViewSpy = vi.fn()
-    const setCreateView = setCreateViewSpy as unknown as Dispatch<SetStateAction<CreateFlowView>>
+    const setCreateView = createSetter<CreateFlowView>()
 
     submitCreateView({
       context,
@@ -29,8 +56,12 @@ describe("app-ready-create", () => {
       setCreateView
     })
 
-    expect(setCreateViewSpy).toHaveBeenCalledTimes(1)
-    const nextView = setCreateViewSpy.mock.calls[0]?.[0]
+    expect(setCreateView).toHaveBeenCalledTimes(1)
+    const nextViewAction = setCreateView.mock.calls[0]?.[0]
+    if (nextViewAction === undefined || typeof nextViewAction === "function") {
+      throw new Error("Expected create view object update")
+    }
+    const nextView = nextViewAction
     expect(nextView).toMatchObject({
       step: 1,
       values: {
@@ -52,8 +83,7 @@ describe("app-ready-create", () => {
 
   it("shows a parse error instead of submitting on invalid inline flags", () => {
     const context = createBrowserActionContext()
-    const setCreateViewSpy = vi.fn()
-    const setCreateView = setCreateViewSpy as unknown as Dispatch<SetStateAction<CreateFlowView>>
+    const setCreateView = createSetter<CreateFlowView>()
 
     submitCreateView({
       context,
@@ -63,7 +93,7 @@ describe("app-ready-create", () => {
       setCreateView
     })
 
-    expect(setCreateViewSpy).not.toHaveBeenCalled()
+    expect(setCreateView).not.toHaveBeenCalled()
     expect(context.setMessage).toHaveBeenCalledWith("Missing value for option: --bogus")
   })
 })