Skip to content

Commit 8ac0e3d

Browse files
committed
fix(e2e): stabilize cache and ssh CI checks
1 parent b85a3d4 commit 8ac0e3d

2 files changed

Lines changed: 23 additions & 4 deletions

File tree

scripts/e2e/clone-cache.sh

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ KEEP="${KEEP:-0}"
1818
dg_ensure_docker "$ROOT/.e2e-bin"
1919

2020
export DOCKER_GIT_PROJECTS_ROOT="$ROOT"
21+
export DOCKER_GIT_STATE_AUTO_PULL=0
2122
export DOCKER_GIT_STATE_AUTO_SYNC=0
2223

2324
REPO_URL="https://github.com/octocat/Hello-World/issues/1"
@@ -32,6 +33,14 @@ fail() {
3233
exit 1
3334
}
3435

36+
reset_shared_clone_cache_volume() {
37+
docker volume create docker-git-shared-cache >/dev/null
38+
docker run --rm \
39+
-v docker-git-shared-cache:/target \
40+
alpine:3.20 \
41+
sh -euc 'mkdir -p /target && find /target -mindepth 1 -maxdepth 1 -exec rm -rf -- {} +'
42+
}
43+
3544
on_error() {
3645
local line="$1"
3746
echo "e2e/clone-cache: failed at line $line" >&2
@@ -144,7 +153,8 @@ EOF_ENV
144153
fi
145154
else
146155
grep -Fq -- "[clone-cache] mirror created: $MIRROR_PREFIX/" "$log_path" \
147-
|| fail "expected cache bootstrap log in first clone"
156+
|| grep -Fq -- "[clone-cache] using mirror: $MIRROR_PREFIX/" "$log_path" \
157+
|| fail "expected cache bootstrap or warm-cache reuse log in first clone"
148158
fi
149159

150160
cleanup_active_case
@@ -153,12 +163,20 @@ EOF_ENV
153163
mkdir -p "$ROOT/.orch/auth/codex" "$ROOT/.orch/env"
154164
: > "$ROOT/authorized_keys"
155165

166+
reset_shared_clone_cache_volume
167+
156168
run_clone_case "first" "0"
157169

158170
FIRST_LOG="$ROOT/clone-cache-first.log"
159-
mirror_line="$(grep -F -- "[clone-cache] mirror created: $MIRROR_PREFIX/" "$FIRST_LOG" | tail -n 1 || true)"
160-
[[ -n "$mirror_line" ]] || fail "expected mirror created log line in first clone logs: $FIRST_LOG"
171+
mirror_line="$(
172+
{
173+
grep -F -- "[clone-cache] mirror created: $MIRROR_PREFIX/" "$FIRST_LOG" || true
174+
grep -F -- "[clone-cache] using mirror: $MIRROR_PREFIX/" "$FIRST_LOG" || true
175+
} | tail -n 1
176+
)"
177+
[[ -n "$mirror_line" ]] || fail "expected mirror log line in first clone logs: $FIRST_LOG"
161178
mirror_path="${mirror_line#*mirror created: }"
179+
mirror_path="${mirror_path#*using mirror: }"
162180
[[ -n "$mirror_path" ]] || fail "failed to parse mirror path from first clone log line: $mirror_line"
163181
MIRROR_NAME="$(basename "$mirror_path")"
164182
[[ -n "$MIRROR_NAME" ]] || fail "failed to parse mirror name from mirror path: $mirror_path"

scripts/e2e/runtime-volumes-ssh.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,8 @@ grep -Fq -- "SSH access: ssh -i $SSH_KEY" "$CLONE_LOG" \
143143
|| fail "expected clone log to print SSH access command"
144144

145145
grep -Fq -- " -p $SSH_PORT dev@localhost" "$CLONE_LOG" \
146-
|| fail "expected clone log to print the published SSH port"
146+
|| grep -Eq -- ' -p 22 dev@[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+' "$CLONE_LOG" \
147+
|| fail "expected clone log to print localhost published port or bridge-ip SSH access"
147148

148149
docker exec -u dev "$CONTAINER_NAME" bash -lc "test -d '$TARGET_DIR/.git'" \
149150
|| fail "expected cloned repo at: $TARGET_DIR"

0 commit comments

Comments
 (0)