fix: satisfy lib lint constraints

Author: skulidropek

packages/lib/src/core/command-builders-shared.ts

@@ -0,0 +1,53 @@
+import { Either } from "effect"
+
+import { type CreateCommand, defaultTemplateConfig, isDockerNetworkMode, type ParseError } from "./domain.js"
+
+const parsePort = (value: string): Either.Either<number, ParseError> => {
+  const parsed = Number(value)
+  if (!Number.isInteger(parsed)) {
+    return Either.left({
+      _tag: "InvalidOption",
+      option: "--ssh-port",
+      reason: `expected integer, got: ${value}`
+    })
+  }
+  if (parsed < 1 || parsed > 65_535) {
+    return Either.left({
+      _tag: "InvalidOption",
+      option: "--ssh-port",
+      reason: "must be between 1 and 65535"
+    })
+  }
+  return Either.right(parsed)
+}
+
+export const parseSshPort = (value: string): Either.Either<number, ParseError> => parsePort(value)
+
+export const parseDockerNetworkMode = (
+  value: string | undefined
+): Either.Either<CreateCommand["config"]["dockerNetworkMode"], ParseError> => {
+  const candidate = value?.trim() ?? defaultTemplateConfig.dockerNetworkMode
+  if (isDockerNetworkMode(candidate)) {
+    return Either.right(candidate)
+  }
+  return Either.left({
+    _tag: "InvalidOption",
+    option: "--network-mode",
+    reason: "expected one of: shared, project"
+  })
+}
+
+export const nonEmpty = (
+  option: string,
+  value: string | undefined,
+  fallback?: string
+): Either.Either<string, ParseError> => {
+  const candidate = value?.trim() ?? fallback
+  if (candidate === undefined || candidate.length === 0) {
+    return Either.left({
+      _tag: "MissingRequiredOption",
+      option
+    })
+  }
+  return Either.right(candidate)
+}

packages/lib/src/core/command-builders.ts

@@ -2,6 +2,7 @@ import { Either } from "effect"
 
 import { expandContainerHome } from "../usecases/scrap-path.js"
 import { resolveAutoAgentFlags } from "./auto-agent-flags.js"
+import { nonEmpty, parseDockerNetworkMode, parseSshPort } from "./command-builders-shared.js"
 import { type RawOptions } from "./command-options.js"
 import {
   type AgentMode,
@@ -11,61 +12,14 @@ import {
   defaultTemplateConfig,
   deriveRepoPathParts,
   deriveRepoSlug,
-  isDockerNetworkMode,
   type ParseError,
   resolveRepoInput
 } from "./domain.js"
 import { normalizeCpuLimit, normalizeRamLimit } from "./resource-limits.js"
 import { trimRightChar } from "./strings.js"
 import { normalizeAuthLabel, normalizeGitTokenLabel } from "./token-labels.js"
 
-const parsePort = (value: string): Either.Either<number, ParseError> => {
-  const parsed = Number(value)
-  if (!Number.isInteger(parsed)) {
-    return Either.left({
-      _tag: "InvalidOption",
-      option: "--ssh-port",
-      reason: `expected integer, got: ${value}`
-    })
-  }
-  if (parsed < 1 || parsed > 65_535) {
-    return Either.left({
-      _tag: "InvalidOption",
-      option: "--ssh-port",
-      reason: "must be between 1 and 65535"
-    })
-  }
-  return Either.right(parsed)
-}
-
-const parseDockerNetworkMode = (
-  value: string | undefined
-): Either.Either<CreateCommand["config"]["dockerNetworkMode"], ParseError> => {
-  const candidate = value?.trim() ?? defaultTemplateConfig.dockerNetworkMode
-  if (isDockerNetworkMode(candidate)) {
-    return Either.right(candidate)
-  }
-  return Either.left({
-    _tag: "InvalidOption",
-    option: "--network-mode",
-    reason: "expected one of: shared, project"
-  })
-}
-
-export const nonEmpty = (
-  option: string,
-  value: string | undefined,
-  fallback?: string
-): Either.Either<string, ParseError> => {
-  const candidate = value?.trim() ?? fallback
-  if (candidate === undefined || candidate.length === 0) {
-    return Either.left({
-      _tag: "MissingRequiredOption",
-      option
-    })
-  }
-  return Either.right(candidate)
-}
+export { nonEmpty } from "./command-builders-shared.js"
 
 const normalizeSecretsRoot = (value: string): string => trimRightChar(value, "/")
 
@@ -98,7 +52,7 @@ const resolveRepoBasics = (raw: RawOptions): Either.Either<RepoBasics, ParseErro
       nonEmpty("--target-dir", raw.targetDir, defaultTemplateConfig.targetDir)
     )
     const targetDir = expandContainerHome(sshUser, rawTargetDir)
-    const sshPort = yield* _(parsePort(raw.sshPort ?? String(defaultTemplateConfig.sshPort)))
+    const sshPort = yield* _(parseSshPort(raw.sshPort ?? String(defaultTemplateConfig.sshPort)))
 
     return { repoUrl, repoSlug, projectSlug, repoPath, repoRef, targetDir, sshUser, sshPort }
   })
@@ -243,13 +197,13 @@ const buildTemplateConfig = ({
   claudeAuthLabel,
   codexAuthLabel,
   cpuLimit,
-  ramLimit,
   dockerNetworkMode,
   dockerSharedNetworkName,
   enableMcpPlaywright,
   gitTokenLabel,
   names,
   paths,
+  ramLimit,
   repo
 }: BuildTemplateConfigInput): CreateCommand["config"] => ({
   containerName: names.containerName,

packages/lib/src/core/resource-limits.ts

@@ -21,8 +21,9 @@ const cpuAbsolutePattern = /^\d+(?:\.\d+)?$/u
 const ramAbsolutePattern = /^\d+(?:\.\d+)?(?:b|k|kb|m|mb|g|gb|t|tb)$/iu
 const percentPattern = /^\d+(?:\.\d+)?%$/u
 
-const normalizePrecision = (value: number): number =>
-  Math.round(value * precisionScale) / precisionScale
+const normalizePrecision = (value: number): number => Math.round(value * precisionScale) / precisionScale
+
+const missingLimit = (): string | undefined => undefined
 
 const parsePercent = (candidate: string): number | null => {
   if (!percentPattern.test(candidate)) {
@@ -58,7 +59,7 @@ export const normalizeCpuLimit = (
 ): Either.Either<string | undefined, ParseError> => {
   const candidate = value?.trim().toLowerCase() ?? ""
   if (candidate.length === 0) {
-    return Either.right(undefined)
+    return Either.right(missingLimit())
   }
   if (candidate.endsWith("%")) {
     return normalizePercent(candidate, "cpu")
@@ -87,7 +88,7 @@ export const normalizeRamLimit = (
 ): Either.Either<string | undefined, ParseError> => {
   const candidate = value?.trim().toLowerCase() ?? ""
   if (candidate.length === 0) {
-    return Either.right(undefined)
+    return Either.right(missingLimit())
   }
   if (candidate.endsWith("%")) {
     return normalizePercent(candidate, "ram")

packages/lib/src/core/templates/docker-compose.ts

@@ -82,7 +82,9 @@ const buildPlaywrightFragments = (
     maybePlaywrightEnv:
       `      MCP_PLAYWRIGHT_ENABLE: "1"\n      MCP_PLAYWRIGHT_CDP_ENDPOINT: "${browserCdpEndpoint}"\n`,
     maybeBrowserService:
-      `\n  ${browserServiceName}:\n    build:\n      context: .\n      dockerfile: ${browserDockerfile}\n    container_name: ${browserContainerName}\n    restart: unless-stopped\n${renderResourceLimits(resourceLimits)}    environment:\n      VNC_NOPW: "1"\n    shm_size: "2gb"\n    expose:\n      - "9223"\n    volumes:\n      - ${browserVolumeName}:/data\n    networks:\n      - ${networkName}\n`,
+      `\n  ${browserServiceName}:\n    build:\n      context: .\n      dockerfile: ${browserDockerfile}\n    container_name: ${browserContainerName}\n    restart: unless-stopped\n${
+        renderResourceLimits(resourceLimits)
+      }    environment:\n      VNC_NOPW: "1"\n    shm_size: "2gb"\n    expose:\n      - "9223"\n    volumes:\n      - ${browserVolumeName}:/data\n    networks:\n      - ${networkName}\n`,
     maybeBrowserVolume: `  ${browserVolumeName}:\n`
   }
 }

packages/lib/src/shell/files.ts

@@ -1,4 +1,4 @@
-import { availableParallelism, totalmem } from "os"
+import { availableParallelism, totalmem } from "node:os"
 
 import type { PlatformError } from "@effect/platform/Error"
 import type * as FileSystem from "@effect/platform/FileSystem"