fix(auth): claude oauth login UX

Author: skulidropek

packages/lib/src/shell/docker-auth.ts

@@ -14,11 +14,28 @@ export type DockerAuthSpec = {
   readonly image: string
   readonly volume: DockerVolume
   readonly entrypoint?: string
-  readonly env?: string
+  readonly env?: string | ReadonlyArray<string>
   readonly args: ReadonlyArray<string>
   readonly interactive: boolean
 }
 
+const appendEnvArgs = (base: Array<string>, env: string | ReadonlyArray<string>) => {
+  if (typeof env === "string") {
+    const trimmed = env.trim()
+    if (trimmed.length > 0) {
+      base.push("-e", trimmed)
+    }
+    return
+  }
+  for (const entry of env) {
+    const trimmed = entry.trim()
+    if (trimmed.length === 0) {
+      continue
+    }
+    base.push("-e", trimmed)
+  }
+}
+
 const buildDockerArgs = (spec: DockerAuthSpec): ReadonlyArray<string> => {
   const base: Array<string> = ["run", "--rm"]
   if (spec.interactive) {
@@ -28,8 +45,8 @@ const buildDockerArgs = (spec: DockerAuthSpec): ReadonlyArray<string> => {
     base.push("--entrypoint", spec.entrypoint)
   }
   base.push("-v", `${spec.volume.hostPath}:${spec.volume.containerPath}`)
-  if (spec.env && spec.env.length > 0) {
-    base.push("-e", spec.env)
+  if (spec.env !== undefined) {
+    appendEnvArgs(base, spec.env)
   }
   return [...base, spec.image, ...spec.args]
 }

packages/lib/src/usecases/auth-claude.ts

@@ -103,7 +103,7 @@ const runClaudeAuthCommand = (
       image: claudeImageName,
       hostPath: accountPath,
       containerPath: claudeConfigDir,
-      env: `CLAUDE_CONFIG_DIR=${claudeConfigDir}`,
+      env: [`CLAUDE_CONFIG_DIR=${claudeConfigDir}`, "BROWSER=echo"],
       args,
       interactive
     }),
@@ -180,7 +180,10 @@ export const authClaudeLogin = (
     return Effect.fail(new AuthError({ message: "Claude auth login requires an interactive TTY." }))
   }
   const accountLabel = normalizeAccountLabel(command.label, "default")
-  return withClaudeAuth(command, ({ accountPath, cwd }) => runClaudeLogin(cwd, accountPath, true)).pipe(
+  return Effect.log(
+    "Claude OAuth: open the URL, then copy the Authentication Code from the browser and paste it here (input is hidden), then press Enter."
+  ).pipe(
+    Effect.zipRight(withClaudeAuth(command, ({ accountPath, cwd }) => runClaudeLogin(cwd, accountPath, true))),
     Effect.zipRight(autoSyncState(`chore(state): auth claude ${accountLabel}`))
   )
 }

packages/lib/src/usecases/auth-helpers.ts

@@ -7,7 +7,7 @@ type DockerAuthSpecInput = {
   readonly hostPath: string
   readonly containerPath: string
   readonly entrypoint?: string
-  readonly env?: string
+  readonly env?: string | ReadonlyArray<string>
   readonly args: ReadonlyArray<string>
   readonly interactive: boolean
 }
@@ -46,7 +46,7 @@ export const buildDockerAuthSpec = (input: DockerAuthSpecInput): DockerAuthSpec
   image: input.image,
   volume: { hostPath: input.hostPath, containerPath: input.containerPath },
   ...(typeof input.entrypoint === "string" ? { entrypoint: input.entrypoint } : {}),
-  ...(typeof input.env === "string" ? { env: input.env } : {}),
+  ...(input.env === undefined ? {} : { env: input.env }),
   args: input.args,
   interactive: input.interactive
 })