fix(app): satisfy effect lint for host cli

Author: skulidropek

packages/app/src/docker-git/api-http.ts

@@ -2,7 +2,7 @@ import { FetchHttpClient, HttpBody, HttpClient } from "@effect/platform"
 import type * as HttpClientError from "@effect/platform/HttpClientError"
 import { Effect } from "effect"
 
-import { asObject, type JsonRequest, type JsonValue, parseResponseBody } from "./api-json.js"
+import { asObject, asString, type JsonRequest, type JsonValue, parseResponseBody } from "./api-json.js"
 import { resolveApiBaseUrl } from "./controller.js"
 import type { ApiAuthRequiredError, ApiRequestError } from "./host-errors.js"
 
@@ -18,19 +18,44 @@ type ApiErrorEnvelope = {
   }
 }
 
-const jsonHeaders = {
+type ApiErrorPayload = NonNullable<ApiErrorEnvelope["error"]>
+
+const jsonHeaders: Readonly<Record<string, string>> = {
   "content-type": "application/json",
   accept: "application/json"
-} as const
+}
 
 const defaultGithubLoginCommand = "docker-git auth github login --web"
 
 const isApiTransportError = (
   error: ApiTransportError | HttpClientError.HttpClientError
 ): error is ApiTransportError => error._tag === "ApiRequestError" || error._tag === "ApiAuthRequiredError"
 
-const readErrorPayload = (body: JsonValue): ApiErrorEnvelope["error"] | undefined =>
-  (asObject(body) as ApiErrorEnvelope | null)?.error
+const readErrorPayload = (body: JsonValue): ApiErrorPayload | undefined => {
+  const envelope = asObject(body)
+  if (envelope === null) {
+    return undefined
+  }
+
+  const error = asObject(envelope["error"])
+  if (error === null) {
+    return undefined
+  }
+
+  const type = asString(error["type"])
+  const message = asString(error["message"])
+  const provider = asString(error["provider"])
+  const command = asString(error["command"])
+  const details = error["details"]
+
+  return {
+    ...(type === null ? {} : { type }),
+    ...(message === null ? {} : { message }),
+    ...(provider === null ? {} : { provider }),
+    ...(command === null ? {} : { command }),
+    ...(details === undefined ? {} : { details })
+  }
+}
 
 const isAuthRequired = (
   status: number,

packages/app/src/docker-git/controller.ts

@@ -1,8 +1,9 @@
 import { FetchHttpClient, HttpClient } from "@effect/platform"
 import type * as CommandExecutor from "@effect/platform/CommandExecutor"
+import type { PlatformError } from "@effect/platform/Error"
+import * as FileSystem from "@effect/platform/FileSystem"
+import * as Path from "@effect/platform/Path"
 import { Duration, Effect, pipe, Schedule } from "effect"
-import { existsSync } from "node:fs"
-import path from "node:path"
 
 import { runCommandExitCode } from "@lib/shell/command-runner"
 
@@ -11,6 +12,16 @@ import type { ControllerBootstrapError } from "./host-errors.js"
 const defaultApiPort = "3334"
 const defaultApiHost = "127.0.0.1"
 
+type ControllerRuntime =
+  | CommandExecutor.CommandExecutor
+  | FileSystem.FileSystem
+  | Path.Path
+
+const controllerBootstrapError = (message: string): ControllerBootstrapError => ({
+  _tag: "ControllerBootstrapError",
+  message
+})
+
 const trimTrailingSlashes = (value: string): string => {
   const parts = value.split("/")
   let end = parts.length
@@ -33,22 +44,29 @@ export const resolveApiBaseUrl = (): string => {
   return `http://${host}:${port}`
 }
 
-const composeFilePath = (): string => {
-  let current = process.cwd()
-
-  for (;;) {
-    const candidate = path.join(current, "docker-compose.yml")
-    if (existsSync(candidate)) {
-      return candidate
+const composeFilePath = (): Effect.Effect<string, PlatformError, FileSystem.FileSystem | Path.Path> =>
+  Effect.gen(function*(_) {
+    const fs = yield* _(FileSystem.FileSystem)
+    const path = yield* _(Path.Path)
+    let current = process.cwd()
+
+    for (;;) {
+      const candidate = path.join(current, "docker-compose.yml")
+      const exists = yield* _(fs.exists(candidate))
+      if (exists) {
+        return candidate
+      }
+
+      const parent = path.dirname(current)
+      if (parent === current) {
+        return path.resolve(process.cwd(), "docker-compose.yml")
+      }
+      current = parent
     }
+  })
 
-    const parent = path.dirname(current)
-    if (parent === current) {
-      return path.resolve(process.cwd(), "docker-compose.yml")
-    }
-    current = parent
-  }
-}
+const mapComposePathError = (error: PlatformError): ControllerBootstrapError =>
+  controllerBootstrapError(`Failed to resolve docker-compose.yml path.\nDetails: ${String(error)}`)
 
 const runExitCode = (
   command: string,
@@ -58,7 +76,12 @@ const runExitCode = (
     cwd: process.cwd(),
     command,
     args
-  }).pipe(Effect.catchAll(() => Effect.succeed(1)))
+  }).pipe(
+    Effect.match({
+      onFailure: () => 1,
+      onSuccess: (exitCode) => exitCode
+    })
+  )
 
 export const resolveDockerCommand = (): Effect.Effect<
   ReadonlyArray<string>,
@@ -77,15 +100,16 @@ export const resolveDockerCommand = (): Effect.Effect<
 
 const runCompose = (
   args: ReadonlyArray<string>
-): Effect.Effect<void, ControllerBootstrapError, CommandExecutor.CommandExecutor> =>
+): Effect.Effect<void, ControllerBootstrapError, ControllerRuntime> =>
   Effect.gen(function*(_) {
     const dockerCommand = yield* _(resolveDockerCommand())
+    const composePath = yield* _(composeFilePath().pipe(Effect.mapError(mapComposePathError)))
     const command = dockerCommand[0] ?? "docker"
     const commandArgs = [
       ...dockerCommand.slice(1),
       "compose",
       "-f",
-      composeFilePath(),
+      composePath,
       ...args
     ]
     const exitCode = yield* _(runExitCode(command, commandArgs))
@@ -96,14 +120,13 @@ const runCompose = (
 
     return yield* _(
       Effect.fail(
-        {
-          _tag: "ControllerBootstrapError",
-          message: [
+        controllerBootstrapError(
+          [
             "Failed to start docker-git controller.",
             `Command: ${[command, ...commandArgs].join(" ")}`,
             `Exit code: ${exitCode}`
           ].join("\n")
-        } satisfies ControllerBootstrapError
+        )
       )
     )
   })
@@ -119,10 +142,9 @@ const probeHealth = (apiBaseUrl: string): Effect.Effect<void, ControllerBootstra
 
     return yield* _(
       Effect.fail(
-        {
-          _tag: "ControllerBootstrapError",
-          message: `docker-git controller health returned ${response.status} at ${apiBaseUrl}/health`
-        } satisfies ControllerBootstrapError
+        controllerBootstrapError(
+          `docker-git controller health returned ${response.status} at ${apiBaseUrl}/health`
+        )
       )
     )
   }).pipe(
@@ -163,8 +185,10 @@ export const ensureControllerReady = Effect.gen(function*(_) {
   const apiBaseUrl = resolveApiBaseUrl()
   const healthy = yield* _(
     probeHealth(apiBaseUrl).pipe(
-      Effect.as(true),
-      Effect.catchAll(() => Effect.succeed(false))
+      Effect.match({
+        onFailure: () => false,
+        onSuccess: () => true
+      })
     )
   )
 

packages/app/src/docker-git/program.ts

@@ -1,4 +1,3 @@
-import type * as CommandExecutor from "@effect/platform/CommandExecutor"
 import type { Command } from "@lib/core/domain"
 import { Effect, Match, pipe } from "effect"
 
@@ -80,7 +79,7 @@ const unsupported = (command: string, message: string): Effect.Effect<void, Unsu
 
 const withControllerReady = <E>(
   effect: Effect.Effect<void, E>
-): Effect.Effect<void, E | CliError, CommandExecutor.CommandExecutor> =>
+) =>
   pipe(
     ensureControllerReady,
     Effect.zipRight(effect)
@@ -276,6 +275,8 @@ export const program = pipe(
       ? Effect.log(usageText)
       : dispatchOperationalCommand(command)
   ),
-  Effect.catchAll((error: CliError) => logAndExit(error)),
-  Effect.asVoid
+  Effect.matchEffect({
+    onFailure: (error: CliError) => logAndExit(error),
+    onSuccess: () => Effect.void
+  })
 )