Merge pull request #244 from ProverCoderAI/issue-239

feat(app): add container task manager

Author: skulidropek

docs/pr-screenshots/issue-239/ssh-session-taskmanager-button.png

@@ -54,6 +54,7 @@ export type BrowserActionContext = {
   readonly addTerminalSession: (session: ActiveTerminalSession) => void
   readonly githubStatus: GithubAuthStatus | null
   readonly portForwardInput: string
+  readonly projectTasksIncludeDefault: boolean
   readonly reloadDashboard: () => void
   readonly selectedProjectId: string | null
   readonly selectedProjectKey: string | null
@@ -76,6 +77,7 @@ export type BrowserActionContext = {
   readonly setProjectBrowser: Setter<ProjectBrowserSession | null>
   readonly setProjectTaskLogs: Setter<string>
   readonly setProjectTasks: Setter<ContainerTaskSnapshot | null>
+  readonly setProjectTasksIncludeDefault: Setter<boolean>
   readonly setSelectedMenuIndex: Setter<number>
   readonly setSelectedProject: Setter<ProjectDetails | null>
   readonly setSelectedProjectId: Setter<string | null>

docs/pr-screenshots/issue-239/ssh-session-taskmanager-open.png

@@ -1,9 +1,14 @@
-import type { Effect } from "effect"
+import { Effect } from "effect"
 
-import { type BrowserActionContext, requireSelectedProjectId, withBusy } from "./actions-shared.js"
+import { type BrowserActionContext, confirmAction, requireSelectedProjectId, withBusy } from "./actions-shared.js"
 import { loadProjectTaskLogs, loadProjectTasks, stopProjectTask } from "./api.js"
 import type { ContainerTaskSnapshot } from "./api.js"
 
+type LoadSelectedProjectTasksOptions = {
+  readonly includeDefault?: boolean
+  readonly silent?: boolean
+}
+
 const requireProjectIdForTasks = (context: BrowserActionContext): string | null => {
   const projectId = requireSelectedProjectId(context)
   if (projectId === null) {
@@ -66,16 +71,20 @@ const removeTaskFromSnapshot = (
 
 const stopSelectedProjectTaskEffect = (
   selected: SelectedProjectTaskAction
-): Effect.Effect<void, string> => stopProjectTask(selected.projectId, selected.pid)
+): Effect.Effect<ContainerTaskSnapshot, string> =>
+  stopProjectTask(selected.projectId, selected.pid).pipe(
+    Effect.flatMap(() => loadProjectTasks(selected.projectId, selected.context.projectTasksIncludeDefault))
+  )
 
 const loadSelectedProjectTaskLogsEffect = (
   selected: SelectedProjectTaskAction
 ): Effect.Effect<string, string> => loadProjectTaskLogs(selected.projectId, selected.pid, 200)
 
 const applyStoppedProjectTask = (
-  selected: SelectedProjectTaskAction
+  selected: SelectedProjectTaskAction,
+  snapshot: ContainerTaskSnapshot
 ): void => {
-  selected.context.setProjectTasks((snapshot) => removeTaskFromSnapshot(snapshot, selected.pid))
+  selected.context.setProjectTasks(removeTaskFromSnapshot(snapshot, selected.pid))
   selected.context.setMessage(`Sent SIGTERM to PID ${selected.pid}.`)
 }
 
@@ -87,18 +96,16 @@ const applyLoadedProjectTaskLogs = (
   selected.context.setMessage(`Loaded logs for PID ${selected.pid}.`)
 }
 
-export const loadSelectedProjectTasks = (
+export const loadProjectTasksById = (
   context: BrowserActionContext,
-  options?: { readonly silent?: boolean }
+  projectId: string,
+  options?: LoadSelectedProjectTasksOptions
 ) => {
-  const projectId = requireProjectIdForTasks(context)
-  if (projectId === null) {
-    return
-  }
+  const includeDefault = options?.includeDefault ?? context.projectTasksIncludeDefault
   withBusy({
     context,
-    effect: loadProjectTasks(projectId),
-    label: "Loading container tasks",
+    effect: loadProjectTasks(projectId, includeDefault),
+    label: includeDefault ? "Loading all container tasks" : "Loading container tasks",
     onSuccess: (snapshot) => {
       context.setProjectTasks(snapshot)
       if (options?.silent !== true) {
@@ -108,16 +115,46 @@ export const loadSelectedProjectTasks = (
   })
 }
 
+export const loadSelectedProjectTasks = (
+  context: BrowserActionContext,
+  options?: LoadSelectedProjectTasksOptions
+) => {
+  const projectId = requireProjectIdForTasks(context)
+  if (projectId === null) {
+    return
+  }
+  loadProjectTasksById(context, projectId, options)
+}
+
+export const setSelectedProjectTasksIncludeDefault = (
+  context: BrowserActionContext,
+  includeDefault: boolean
+) => {
+  context.setProjectTasksIncludeDefault(includeDefault)
+  context.setProjectTaskLogs("")
+  const projectId = requireProjectIdForTasks(context)
+  if (projectId === null) {
+    return
+  }
+  loadProjectTasksById(context, projectId, { includeDefault })
+}
+
 export const stopSelectedProjectTask = (
   context: BrowserActionContext,
   pid: number
 ) => {
-  withSelectedProjectTaskBusy({
-    context,
-    effect: stopSelectedProjectTaskEffect,
-    label: "Stopping container task",
-    onSuccess: applyStoppedProjectTask,
-    pid
+  withSelectedProjectTask(context, pid, (selected) => {
+    if (!confirmAction(`Stop PID ${selected.pid}?`)) {
+      return
+    }
+    withBusy({
+      context: selected.context,
+      effect: stopSelectedProjectTaskEffect(selected),
+      label: "Stopping container task",
+      onSuccess: (snapshot) => {
+        applyStoppedProjectTask(selected, snapshot)
+      }
+    })
   })
 }
 

docs/screenshots/issue-239/taskmanager-default.png

@@ -38,7 +38,13 @@ export {
   loadSelectedProjectInfo,
   runApplyAllProjects
 } from "./actions-projects.js"
-export { loadSelectedProjectTaskLogs, loadSelectedProjectTasks, stopSelectedProjectTask } from "./actions-tasks.js"
+export {
+  loadProjectTasksById,
+  loadSelectedProjectTaskLogs,
+  loadSelectedProjectTasks,
+  setSelectedProjectTasksIncludeDefault,
+  stopSelectedProjectTask
+} from "./actions-tasks.js"
 
 export const runBrowserMenuAction = (
   currentMenu: BrowserMenuTag,

docs/screenshots/issue-239/taskmanager-show-system.png

@@ -3,10 +3,13 @@ import { Effect } from "effect"
 import { requestJson, requestText } from "./api-http.js"
 import { ContainerTaskSnapshotResponseSchema, OutputResponseSchema } from "./api-schema.js"
 
-export const loadProjectTasks = (projectId: string) =>
+const projectTasksPath = (projectId: string, includeDefault: boolean): string =>
+  `/projects/${encodeURIComponent(projectId)}/tasks${includeDefault ? "?includeDefault=true" : ""}`
+
+export const loadProjectTasks = (projectId: string, includeDefault = false) =>
   requestJson(
     "GET",
-    `/projects/${encodeURIComponent(projectId)}/tasks`,
+    projectTasksPath(projectId, includeDefault),
     ContainerTaskSnapshotResponseSchema
   ).pipe(
     Effect.map((response) => response.snapshot)

packages/app/src/web/actions-shared.ts

@@ -11,6 +11,7 @@ type ActionContextArgs = {
   readonly addTerminalSession: BrowserActionContext["addTerminalSession"]
   readonly githubStatus: BrowserActionContext["githubStatus"]
   readonly portForwardInput: BrowserActionContext["portForwardInput"]
+  readonly projectTasksIncludeDefault: BrowserActionContext["projectTasksIncludeDefault"]
   readonly refreshDashboard: () => void
   readonly selectedProjectId: string | null
   readonly selectedProjectKey: string | null
@@ -33,6 +34,7 @@ type ActionContextArgs = {
   readonly setProjectBrowser: BrowserActionContext["setProjectBrowser"]
   readonly setProjectTaskLogs: BrowserActionContext["setProjectTaskLogs"]
   readonly setProjectTasks: BrowserActionContext["setProjectTasks"]
+  readonly setProjectTasksIncludeDefault: BrowserActionContext["setProjectTasksIncludeDefault"]
   readonly setSelectedMenuIndex: BrowserActionContext["setSelectedMenuIndex"]
   readonly setSelectedProject: BrowserActionContext["setSelectedProject"]
   readonly setSelectedProjectId: BrowserActionContext["setSelectedProjectId"]
@@ -47,6 +49,7 @@ export const createActionContext = (args: ActionContextArgs): BrowserActionConte
   databaseLabelInput: args.databaseLabelInput,
   githubStatus: args.githubStatus,
   portForwardInput: args.portForwardInput,
+  projectTasksIncludeDefault: args.projectTasksIncludeDefault,
   reloadDashboard: args.refreshDashboard,
   selectedProjectId: args.selectedProjectId,
   selectedProjectKey: args.selectedProjectKey,
@@ -69,6 +72,7 @@ export const createActionContext = (args: ActionContextArgs): BrowserActionConte
   setProjectBrowser: args.setProjectBrowser,
   setProjectTaskLogs: args.setProjectTaskLogs,
   setProjectTasks: args.setProjectTasks,
+  setProjectTasksIncludeDefault: args.setProjectTasksIncludeDefault,
   setSelectedMenuIndex: args.setSelectedMenuIndex,
   setSelectedProject: args.setSelectedProject,
   setSelectedProjectId: args.setSelectedProjectId

packages/app/src/web/actions-tasks.ts

@@ -17,6 +17,7 @@ export const createReadyActionContext = (
     databaseLabelInput: state.databaseLabelInput,
     githubStatus: state.githubStatus,
     portForwardInput: state.portForwardInput,
+    projectTasksIncludeDefault: state.projectTasksIncludeDefault,
     refreshDashboard,
     selectedProjectId: state.selectedProjectId,
     selectedProjectKey: selectedProjectSummary?.projectKey ?? null,
@@ -39,6 +40,7 @@ export const createReadyActionContext = (
     setProjectBrowser: state.setProjectBrowser,
     setProjectTaskLogs: state.setProjectTaskLogs,
     setProjectTasks: state.setProjectTasks,
+    setProjectTasksIncludeDefault: state.setProjectTasksIncludeDefault,
     setSelectedMenuIndex: state.setSelectedMenuIndex,
     setSelectedProject: state.setSelectedProject,
     setSelectedProjectId: state.setSelectedProjectId