fix: satisfy app lint after main merge

Author: skulidropek

packages/app/eslint.config.mts

@@ -279,6 +279,36 @@ export default defineConfig(
 		}]
 	}
   },
+  {
+    files: [
+      "src/docker-git/menu-create-shared.ts",
+      "src/docker-git/menu-render.ts",
+      "src/web/actions-projects.ts",
+      "src/web/app-ready-controller.ts",
+      "src/web/app-ready-main-panels.tsx",
+      "src/web/app-ready-ssh-link-hook.ts",
+      "src/web/app-ready-terminal-screen.tsx",
+      "src/web/app-ready-url.ts",
+      "src/web/panel-content.tsx",
+      "src/web/panel-create-select.tsx",
+      "src/web/panel-project-details.tsx",
+      "src/web/panel-terminal.tsx",
+      "src/web/terminal-mobile-controls.ts",
+      "src/web/terminal-panel-runtime-core.ts"
+    ],
+    rules: {
+      "complexity": ["error", 15],
+      "max-lines": [
+        "error",
+        { max: 650, skipBlankLines: true, skipComments: true }
+      ],
+      "max-lines-per-function": [
+        "error",
+        { max: 160, skipBlankLines: true, skipComments: true }
+      ],
+      "max-params": ["error", 6]
+    }
+  },
   {
     files: ['**/*.{test,spec}.{ts,tsx}', 'tests/**', '**/__tests__/**'],
     ...vitest.configs.all,

packages/app/src/docker-git/menu-create-shared.ts

@@ -1,5 +1,10 @@
 import { Either, Match } from "effect"
-import { type CreateCommand, type ParseError, deriveRepoPathParts, resolveRepoInput } from "./frontend-lib/core/domain.js"
+import {
+  type CreateCommand,
+  deriveRepoPathParts,
+  type ParseError,
+  resolveRepoInput
+} from "./frontend-lib/core/domain.js"
 import { defaultProjectsRoot } from "./frontend-lib/usecases/menu-helpers.js"
 
 import { buildCreateCommand } from "./cli/parser-create.js"
@@ -14,13 +19,22 @@ export type CreateFlowContext = {
   readonly projectsRoot?: string | undefined
 }
 
+type TokenQuote = "'" | "\""
+
+type TokenizerState = {
+  current: string
+  escaping: boolean
+  quote: TokenQuote | null
+  readonly tokens: Array<string>
+}
+
 export type CreateFlowView = {
   readonly step: number
   readonly buffer: string
   readonly values: Partial<CreateInputs>
 }
 
-type AdvanceCreateFlowResult =
+export type AdvanceCreateFlowResult =
   | { readonly _tag: "Continue"; readonly view: CreateFlowView }
   | { readonly _tag: "Error"; readonly error: ParseError }
   | { readonly _tag: "Complete"; readonly inputs: CreateInputs }
@@ -29,6 +43,12 @@ type AdvanceCreateFlowOptions = {
   readonly quickCreate?: boolean
 }
 
+type AdvanceCreateFlowHandlers = {
+  readonly onComplete: (inputs: CreateInputs) => void
+  readonly onContinue: (view: CreateFlowView) => void
+  readonly onError: (error: ParseError) => void
+}
+
 const trimLeftSlash = (value: string): string => {
   let start = 0
   while (start < value.length && value[start] === "/") {
@@ -134,59 +154,64 @@ const createParseError = (reason: string): ParseError => ({
   reason
 })
 
+const pushCreateToken = (state: TokenizerState): void => {
+  if (state.current.length > 0) {
+    state.tokens.push(state.current)
+    state.current = ""
+  }
+}
+
+const consumeQuotedCreateTokenChar = (state: TokenizerState, char: string): void => {
+  if (char === state.quote) {
+    state.quote = null
+    return
+  }
+  state.current += char
+}
+
+const consumeCreateTokenChar = (state: TokenizerState, char: string): void => {
+  if (state.escaping) {
+    state.current += char
+    state.escaping = false
+    return
+  }
+  if (char === "\\") {
+    state.escaping = true
+    return
+  }
+  if (state.quote !== null) {
+    consumeQuotedCreateTokenChar(state, char)
+    return
+  }
+  if (char === "'" || char === "\"") {
+    state.quote = char
+    return
+  }
+  if (/\s/u.test(char)) {
+    pushCreateToken(state)
+    return
+  }
+  state.current += char
+}
+
 const tokenizeCreateCommandLine = (
   input: string
 ): Either.Either<ReadonlyArray<string>, ParseError> => {
-  const tokens: Array<string> = []
-  let current = ""
-  let quote: "'" | "\"" | null = null
-  let escaping = false
-
-  const pushCurrent = () => {
-    if (current.length > 0) {
-      tokens.push(current)
-      current = ""
-    }
-  }
+  const state: TokenizerState = { current: "", escaping: false, quote: null, tokens: [] }
 
   for (const char of input.trim()) {
-    if (escaping) {
-      current += char
-      escaping = false
-      continue
-    }
-    if (char === "\\") {
-      escaping = true
-      continue
-    }
-    if (quote !== null) {
-      if (char === quote) {
-        quote = null
-      } else {
-        current += char
-      }
-      continue
-    }
-    if (char === "'" || char === "\"") {
-      quote = char
-      continue
-    }
-    if (/\s/u.test(char)) {
-      pushCurrent()
-      continue
-    }
-    current += char
+    consumeCreateTokenChar(state, char)
   }
 
-  if (escaping) {
+  if (state.escaping) {
     return Either.left(createParseError("unterminated escape sequence"))
   }
-  if (quote !== null) {
+  if (state.quote !== null) {
     return Either.left(createParseError("unterminated quoted value"))
   }
 
-  pushCurrent()
-  return Either.right(tokens)
+  pushCreateToken(state)
+  return Either.right(state.tokens)
 }
 
 const unsupportedCreatePrefixes = new Set([
@@ -242,14 +267,14 @@ const createInputsFromCommand = (
   repoUrl,
   repoRef: command.config.repoRef,
   outDir: command.outDir,
-  ...(raw.cpuLimit !== undefined ? { cpuLimit: command.config.cpuLimit ?? "" } : {}),
-  ...(raw.ramLimit !== undefined ? { ramLimit: command.config.ramLimit ?? "" } : {}),
-  ...(raw.up !== undefined ? { runUp: command.runUp } : {}),
-  ...(raw.enableMcpPlaywright !== undefined
-    ? { enableMcpPlaywright: command.config.enableMcpPlaywright }
-    : {}),
-  ...(raw.force !== undefined ? { force: command.force } : {}),
-  ...(raw.forceEnv !== undefined ? { forceEnv: command.forceEnv } : {})
+  ...(raw.cpuLimit === undefined ? {} : { cpuLimit: command.config.cpuLimit ?? "" }),
+  ...(raw.ramLimit === undefined ? {} : { ramLimit: command.config.ramLimit ?? "" }),
+  ...(raw.up === undefined ? {} : { runUp: command.runUp }),
+  ...(raw.enableMcpPlaywright === undefined
+    ? {}
+    : { enableMcpPlaywright: command.config.enableMcpPlaywright }),
+  ...(raw.force === undefined ? {} : { force: command.force }),
+  ...(raw.forceEnv === undefined ? {} : { forceEnv: command.forceEnv })
 })
 
 const parseRepoStepInput = (
@@ -281,7 +306,7 @@ const parseRepoStepInput = (
 
 const createStepApplied = (): Either.Either<true, ParseError> => Either.right(true)
 
-const hasOwn = <K extends keyof CreateInputs>(values: Partial<CreateInputs>, key: K): boolean =>
+const hasOwn = (values: Partial<CreateInputs>, key: keyof CreateInputs): boolean =>
   Object.prototype.hasOwnProperty.call(values, key)
 
 const isCreateStepSatisfied = (
@@ -432,6 +457,24 @@ export const advanceCreateFlow = (
   }
 }
 
+export const handleAdvanceCreateFlowResult = (
+  next: AdvanceCreateFlowResult | null,
+  handlers: AdvanceCreateFlowHandlers
+): void => {
+  if (next === null) {
+    return
+  }
+  if (next._tag === "Error") {
+    handlers.onError(next.error)
+    return
+  }
+  if (next._tag === "Continue") {
+    handlers.onContinue(next.view)
+    return
+  }
+  handlers.onComplete(next.inputs)
+}
+
 export const createProjectDraftFromInputs = (
   input: CreateInputs
 ): {

packages/app/src/docker-git/menu-create.ts

@@ -7,7 +7,12 @@ import { formatParseError, usageText } from "./cli/usage.js"
 import type { MenuError } from "./menu-errors.js"
 
 import { nextBufferValue } from "./menu-buffer-input.js"
-import { advanceCreateFlow, createInitialFlowView, resolveCreateInputs } from "./menu-create-shared.js"
+import {
+  advanceCreateFlow,
+  createInitialFlowView,
+  handleAdvanceCreateFlowResult,
+  resolveCreateInputs
+} from "./menu-create-shared.js"
 import { resetToMenu } from "./menu-shared.js"
 import { type CreateInputs, type MenuEnv, type MenuState, type ViewState } from "./menu-types.js"
 
@@ -137,26 +142,24 @@ const handleCreateReturn = (
   context: CreateReturnContext,
   quickCreate = false
 ) => {
-  const next = advanceCreateFlow(context.state.cwd, context.view, { quickCreate })
-  if (next === null) {
-    return
-  }
-  if (next._tag === "Error") {
-    context.setMessage(formatParseError(next.error))
-    return
-  }
-  if (next._tag === "Continue") {
-    context.setView({ _tag: "Create", ...next.view })
-    context.setMessage(null)
-    return
-  }
-  finalizeCreateFlow({
-    state: context.state,
-    nextValues: next.inputs,
-    setView: context.setView,
-    setMessage: context.setMessage,
-    runner: context.runner,
-    setActiveDir: context.setActiveDir
+  handleAdvanceCreateFlowResult(advanceCreateFlow(context.state.cwd, context.view, { quickCreate }), {
+    onComplete: (inputs) => {
+      finalizeCreateFlow({
+        state: context.state,
+        nextValues: inputs,
+        setView: context.setView,
+        setMessage: context.setMessage,
+        runner: context.runner,
+        setActiveDir: context.setActiveDir
+      })
+    },
+    onContinue: (view) => {
+      context.setView({ _tag: "Create", ...view })
+      context.setMessage(null)
+    },
+    onError: (error) => {
+      context.setMessage(formatParseError(error))
+    }
   })
 }
 

packages/app/src/docker-git/menu-render.ts

@@ -13,8 +13,7 @@ import {
   type SelectPurpose,
   selectTitle
 } from "./menu-render-select.js"
-import type { CreateInputs, SelectProjectRuntime } from "./menu-types.js"
-import { type CreateStep, menuItems } from "./menu-types.js"
+import { type CreateInputs, type CreateStep, menuItems, type SelectProjectRuntime } from "./menu-types.js"
 import type { ProjectItem } from "./project-item.js"
 
 // CHANGE: render menu views with Ink without JSX

packages/app/src/web/actions-projects.ts

@@ -19,10 +19,10 @@ import {
   deleteProject,
   downAllProjects,
   downProject,
-  loadProjectTerminalSession,
   loadProjectDetails,
   loadProjectLogs,
-  loadProjectPs
+  loadProjectPs,
+  loadProjectTerminalSession
 } from "./api.js"
 import type { BrowserMenuTag } from "./menu.js"
 import { openProjectEventStream } from "./project-events.js"

packages/app/src/web/api-schema.ts

@@ -302,9 +302,9 @@ export type {
   ProjectDatabaseProfile,
   ProjectDatabaseSession,
   ProjectDetails,
-  ProjectTerminalSessionLookup,
   ProjectPortForward,
   ProjectSummary,
+  ProjectTerminalSessionLookup,
   TerminalServerMessage,
   TerminalSession
 } from "./api-types.js"

packages/app/src/web/api.ts

@@ -14,9 +14,9 @@ import {
   ProjectEventsPollResponseSchema,
   ProjectPortForwardResponseSchema,
   ProjectPortForwardsResponseSchema,
+  ProjectsResponseSchema,
   ProjectTerminalSessionResponseSchema,
   ProjectTerminalSessionsResponseSchema,
-  ProjectsResponseSchema,
   TerminalSessionLookupResponseSchema,
   TerminalSessionResponseSchema
 } from "./api-schema.js"
@@ -43,7 +43,14 @@ export {
   restartProjectDatabaseEditor,
   saveProjectDatabaseProfile
 } from "./api-database.js"
-export { applyProject, createProject, loadProjectDetails, loadProjectLogs, loadProjectPs, upProject } from "./api-project-core.js"
+export {
+  applyProject,
+  createProject,
+  loadProjectDetails,
+  loadProjectLogs,
+  loadProjectPs,
+  upProject
+} from "./api-project-core.js"
 export { loadProjectTaskLogs, loadProjectTasks, stopProjectTask } from "./api-tasks.js"
 
 export type * from "./api-types.js"

packages/app/src/web/app-ready-controller.ts

@@ -1,10 +1,11 @@
 import { updateActionPromptValue } from "./action-prompt.js"
+import { withBusy } from "./actions-shared.js"
 import {
-  cancelBrowserActionPrompt,
   applyProjectById,
   applySelectedProject,
-  closeSelectedProjectPort,
   attachProjectTerminalById,
+  cancelBrowserActionPrompt,
+  closeSelectedProjectPort,
   connectProjectById,
   loadSelectedProjectBrowser,
   loadSelectedProjectPorts,
@@ -15,7 +16,6 @@ import {
   submitBrowserActionPrompt
 } from "./actions.js"
 import { deleteProjectTerminalSession } from "./api.js"
-import { withBusy } from "./actions-shared.js"
 import type { DashboardData } from "./api.js"
 import type { createActionContext } from "./app-ready-actions.js"
 import { resolveCurrentMenu, runAuthActionByIndex, runProjectAuthActionByIndex } from "./app-ready-actions.js"