fix(api): disable tmux right-click menu

Author: skulidropek

packages/api/src/services/terminal-sessions.ts

@@ -765,6 +765,27 @@ const writePtyInput = (pty: PtyBridge | null, data: string): void => {
 
 const shellQuote = (value: string): string => `'${value.replace(/'/gu, "'\\''")}'`
 
+const tmuxRightClickPaneBindings: ReadonlyArray<string> = ["MouseDown3Pane", "M-MouseDown3Pane"]
+const tmuxRightClickStatusBindings: ReadonlyArray<string> = [
+  "MouseDown3Status",
+  "MouseDown3StatusLeft",
+  "M-MouseDown3Status",
+  "M-MouseDown3StatusLeft"
+]
+
+const renderTmuxPaneRightClickBinding = (binding: string): string =>
+  `tmux bind-key -T root ${binding} if-shell -F -t = ${shellQuote("#{mouse_any_flag}")} ${
+    shellQuote("send-keys -M")
+  } >/dev/null 2>&1 || true`
+
+const renderTmuxStatusRightClickUnbind = (binding: string): string =>
+  `tmux unbind-key -T root ${binding} >/dev/null 2>&1 || true`
+
+const renderTmuxRightClickBindingCommands = (): ReadonlyArray<string> => [
+  ...tmuxRightClickPaneBindings.map(renderTmuxPaneRightClickBinding),
+  ...tmuxRightClickStatusBindings.map(renderTmuxStatusRightClickUnbind)
+]
+
 const writeBufferToProjectContainer = (
   containerName: string,
   containerPath: string,
@@ -982,6 +1003,7 @@ export const renderTmuxAttachCommand = (
     `tmux set-option -t ${shellQuote(args.tmuxName)} status off >/dev/null 2>&1 || true`,
     `tmux set-option -t ${shellQuote(args.tmuxName)} history-limit 50000 >/dev/null 2>&1 || true`,
     `tmux set-option -t ${shellQuote(args.tmuxName)} mouse on >/dev/null 2>&1 || true`,
+    ...renderTmuxRightClickBindingCommands(),
     `exec tmux attach-session -t ${shellQuote(args.tmuxName)}`
   ].join("; ")
   return `bash --noprofile --norc -lc ${shellQuote(script)}`

packages/api/tests/terminal-sessions.test.ts

@@ -254,6 +254,15 @@ describe("terminal sessions service", () => {
     expect(command).toContain("status off")
     expect(command).toContain("history-limit 50000")
     expect(command).toContain("mouse on")
+    expect(command).toContain("bind-key -T root MouseDown3Pane")
+    expect(command).toContain("bind-key -T root M-MouseDown3Pane")
+    expect(command).toContain("#{mouse_any_flag}")
+    expect(command).toContain("send-keys -M")
+    expect(command).toContain("unbind-key -T root MouseDown3Status")
+    expect(command).toContain("unbind-key -T root MouseDown3StatusLeft")
+    expect(command).toContain("unbind-key -T root M-MouseDown3Status")
+    expect(command).toContain("unbind-key -T root M-MouseDown3StatusLeft")
+    expect(command).not.toContain("display-menu")
     expect(command).toContain("tmux attach-session -t")
     expect(command).toContain("docker-git-session-1")
     expect(command).toContain("/home/dev/project with spaces")
@@ -264,6 +273,7 @@ describe("terminal sessions service", () => {
     const statusOffIndex = command.indexOf("status off")
     const sessionHistoryLimitIndex = command.lastIndexOf("history-limit 50000")
     const mouseOnIndex = command.indexOf("mouse on")
+    const rightClickBindingIndex = command.indexOf("MouseDown3Pane")
     const attachSessionIndex = command.indexOf("tmux attach-session -t")
 
     expect(startServerIndex).toBeGreaterThanOrEqual(0)
@@ -272,13 +282,15 @@ describe("terminal sessions service", () => {
     expect(statusOffIndex).toBeGreaterThanOrEqual(0)
     expect(sessionHistoryLimitIndex).toBeGreaterThanOrEqual(0)
     expect(mouseOnIndex).toBeGreaterThanOrEqual(0)
+    expect(rightClickBindingIndex).toBeGreaterThan(mouseOnIndex)
     expect(attachSessionIndex).toBeGreaterThanOrEqual(0)
     expect(startServerIndex).toBeLessThan(globalHistoryLimitIndex)
     expect(globalHistoryLimitIndex).toBeLessThan(newSessionIndex)
     expect(newSessionIndex).toBeLessThan(statusOffIndex)
     expect(statusOffIndex).toBeLessThan(sessionHistoryLimitIndex)
     expect(sessionHistoryLimitIndex).toBeLessThan(mouseOnIndex)
-    expect(mouseOnIndex).toBeLessThan(attachSessionIndex)
+    expect(mouseOnIndex).toBeLessThan(rightClickBindingIndex)
+    expect(rightClickBindingIndex).toBeLessThan(attachSessionIndex)
   })
 
   it("fails before creating a durable session when tmux is unavailable", async () => {