Skip to content

fix(playground): align Night Owl theme with website Prism rendering #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taiman724 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(playground): align Night Owl theme with website Prism rendering #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/scripts/repl-init.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,23 @@ import { prettify } from "htmlfy";
// TODO: https://github.com/brijeshb42/monaco-themes/issues/65
import nightOwlTheme from "../../node_modules/monaco-themes/themes/Night Owl.json" with { type: "json" };

// Token rule overrides applied on top of monaco-themes' Night Owl so the
// playground matches the Prism "Night Owl" theme used on the wcc.dev website
// (https://github.com/PrismJS/prism-themes/blob/master/themes/prism-night-owl.css).
// Monaco rules are evaluated in order, so appending these makes them win over
// the imported defaults for the same token scopes. See issue #23.
const prismAlignedRules: monaco.editor.ITokenThemeRule[] = [
// Prism styles comments in italic; monaco-themes' Night Owl leaves them upright.
{ token: "comment", foreground: "637777", fontStyle: "italic" },
{ token: "comment.line.double-slash", foreground: "637777", fontStyle: "italic" },
// Prism uses a single green (rgb(173,219,103) = #addb67) for all .token.string,
// while monaco-themes' Night Owl uses peach (#ecc48d) for `string.quoted.*`.
// Align the JS/TS string scopes that the playground actually renders.
{ token: "string.quoted", foreground: "addb67" },
{ token: "string.quoted.double", foreground: "addb67" },
{ token: "string.quoted.single", foreground: "addb67" },
];

const inputContainer = document.getElementById("input-content") as HTMLDivElement;
const outputContainer = document.getElementById("output-content") as HTMLDivElement;
const workerUrl = new URL("./repl.ts", import.meta.url);
Expand Down Expand Up @@ -61,6 +78,7 @@ monaco.editor.defineTheme("custom-theme", {
...nightOwlTheme,
// have to specify `base` explicitly or else TS complains
base: "vs-dark",
rules: [...nightOwlTheme.rules, ...prismAlignedRules],
});

const commonSettings = {
Expand Down