-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Description
Issue
Problem:
This combination of tags is not being routed:
highway=service
service=driveway
access=private
Expected:
In my opinion, this is ok, if access=private and there is an alternative route around, but, if it's the only route (the endpoint) to the destination, I dare say, it SHOULD be routed (but I am not a lawayer!).
I checked the osm profile and found this line in the code:
https://github.com/fossgis-routing-server/cbf-routing-profiles/blob/master/car.lua#L90
Maybe it would be possible to add some kind of if is directly connected to endpoint of destination and no alternative route exists, then route.
Additional Info:
According to Tag:highway=service these tags are currently used to give access to a building, parking lot, service station, business estate, beach, campsite, etc.
They are very common too, which means the community is following this standard and it is (for the time being) the proper way to tag:
highway=service: 62.298.180 uses
service=driveway: 17.863.005 uses
The german wiki has great recommendations for using access=private in combination with service=driveway, which is not reflected in the english wiki, so there is a todo to rewrite the english wiki. Because of this, I assume a lot of service=driveway could have been wrongly tagged.
Steps to reproduce
osrm-backendversion being used: v5.27.1
Examples:
- Incorrect Routing to Address – 4308 Eld Ln NW, Olympia, WA 98502 #7167 (comment)
- Hubertussteig 7 currently: https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=49.4982203%2C11.5556486%3B49.4984014%2C11.5728388#map=18/49.498580/11.571903

- Hubertussteig 7 expected: https://www.openstreetmap.org/directions?engine=graphhopper_car&route=49.4982203%2C11.5556486%3B49.4984014%2C11.5728388#map=19/49.498551/11.572813

- Weigendorf, Ernhüller Straße 4 currently: https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=49.4982203%2C11.5556486%3B49.5001194%2C11.5711858#map=17/49.499441/11.571060

- Weigendorf, Ernhüller Straße 4 expected: https://www.openstreetmap.org/directions?engine=fossgis_valhalla_car&route=49.4982203%2C11.5556486%3B49.5001194%2C11.5711858

- Hartmannshof, Schulstraße 3: currently: https://www.openstreetmap.org/directions?engine=fossgis_osrm_car&route=49.4989591%2C11.5557481%3B49.4979852%2C11.5636386#map=17/49.498368/11.560503

- Hartmannshof, Schulstraße 3: expected: https://www.openstreetmap.org/directions?engine=fossgis_valhalla_car&route=49.4989591%2C11.5557481%3B49.4979852%2C11.5636386#map=17/49.498410/11.559548
