Cursor Bot Fix: Fix ineffective system categories/templates test

Author: sanjacornelius

ProcessMaker/Jobs/EvaluateProcessRetentionJob.php

@@ -51,6 +51,24 @@ public function handle(): void
             return;
         }
 
+        // Skip template processes
+        if ($process->is_template) {
+            Log::info('EvaluateProcessRetentionJob: Skipping template process', [
+                'process_id' => $this->processId,
+            ]);
+
+            return;
+        }
+
+        // Skip processes in system categories
+        if ($process->categories()->where('is_system', true)->exists()) {
+            Log::info('EvaluateProcessRetentionJob: Skipping process in system category', [
+                'process_id' => $this->processId,
+            ]);
+
+            return;
+        }
+
         // Default to 1_year if retention_period is not set
         $retentionPeriod = $process->properties['retention_period'] ?? '1_year';
         $retentionMonths = match ($retentionPeriod) {

tests/Jobs/EvaluateProcessRetentionJobTest.php

@@ -335,21 +335,34 @@ public function testItDoesNotRunForTemplates()
         // Create a template process
         $process = Process::factory()->create([
             'is_template' => 1,
+            'properties' => [
+                'retention_period' => self::RETENTION_PERIOD,
+            ],
         ]);
         $process->save();
         $process->refresh();
 
-        // Dispatch the job
-        EvaluateProcessRetentionJob::dispatchSync($process->id);
-
-        // The case should NOT be deleted because the process is a template
-        $this->assertDatabaseCount('case_numbers', 0);
-
         // Create a process request
         $processRequest = ProcessRequest::factory()->create();
         $processRequest->process_id = $process->id;
         $processRequest->save();
         $processRequest->refresh();
+
+        // Create an old case that should be deleted if this wasn't a template
+        // 13 months ago is older than 1 year retention period
+        $oldCaseDate = Carbon::now()->subMonths(13);
+        $oldCase = CaseNumber::factory()->create([
+            'process_request_id' => $processRequest->id,
+        ]);
+        $oldCase->created_at = $oldCaseDate;
+        $oldCase->save();
+
+        // Dispatch the job
+        EvaluateProcessRetentionJob::dispatchSync($process->id);
+
+        // The case should NOT be deleted because the process is a template
+        $this->assertNotNull(CaseNumber::find($oldCase->id), 'The case should NOT be deleted because the process is a template');
+        $this->assertDatabaseCount('case_numbers', 2);
     }
 
     public function testItDoesNotRunForProcessesInSystemCategories()
@@ -360,14 +373,33 @@ public function testItDoesNotRunForProcessesInSystemCategories()
         // Create a process in a system category
         $process = Process::factory()->create([
             'process_category_id' => $category->id,
+            'properties' => [
+                'retention_period' => self::RETENTION_PERIOD,
+            ],
         ]);
         $process->save();
         $process->refresh();
 
+        // Create a process request
+        $processRequest = ProcessRequest::factory()->create();
+        $processRequest->process_id = $process->id;
+        $processRequest->save();
+        $processRequest->refresh();
+
+        // Create an old case that should be deleted if this wasn't in a system category
+        // 13 months ago is older than 1 year retention period
+        $oldCaseDate = Carbon::now()->subMonths(13);
+        $oldCase = CaseNumber::factory()->create([
+            'process_request_id' => $processRequest->id,
+        ]);
+        $oldCase->created_at = $oldCaseDate;
+        $oldCase->save();
+
         // Dispatch the job
         EvaluateProcessRetentionJob::dispatchSync($process->id);
 
         // The case should NOT be deleted because the process is in a system category
-        $this->assertDatabaseCount('case_numbers', 0);
+        $this->assertNotNull(CaseNumber::find($oldCase->id), 'The case should NOT be deleted because the process is in a system category');
+        $this->assertDatabaseCount('case_numbers', 2);
     }
 }