Skip to content

fix: user settings PATCH treats null body values as field omission #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmdeveloper007 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: user settings PATCH treats null body values as field omission #842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/app/api/user/settings/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,21 +157,25 @@ export async function PATCH(req: NextRequest) {
}

const { hasLeaderboardOptIn, hasPinnedRepos } = settingsResult;

const updates: { is_public?: boolean; leaderboard_opt_in?: boolean; pinned_repos?: string[] } = {};

if (typeof is_public === "boolean") {
if (is_public !== undefined && is_public !== null && typeof is_public === "boolean") {
updates.is_public = is_public;
}

if (hasLeaderboardOptIn && typeof leaderboard_opt_in === "boolean") {
if (
hasLeaderboardOptIn &&
leaderboard_opt_in !== undefined &&
leaderboard_opt_in !== null &&
typeof leaderboard_opt_in === "boolean"
) {
updates.leaderboard_opt_in = leaderboard_opt_in;
if (leaderboard_opt_in) {
updates.is_public = true;
}
}

if (hasPinnedRepos && Array.isArray(pinned_repos)) {
if (hasPinnedRepos && pinned_repos !== undefined && pinned_repos !== null && Array.isArray(pinned_repos)) {
if (pinned_repos.length > 3) {
return NextResponse.json({ error: "Maximum 3 pins allowed" }, { status: 400 });
}
Expand Down
Loading