Replace HashtableAst.SafeGetValue() compatibility shim with actual implementation

liamjpeters · liamjpeters · commit 3d8013afb5e3 · 2026-01-12T13:21:43.000Z
diff --git a/Engine/Settings.cs b/Engine/Settings.cs
@@ -462,9 +462,7 @@ private void parseSettingsFile(string settingsFilePath)
             Hashtable hashtable;
             try
             {
-                // ideally we should use HashtableAst.SafeGetValue() but since
-                // it is not available on PSv3, we resort to our own narrow implementation.
-                hashtable = Helper.GetSafeValueFromHashtableAst(hashTableAst);
+                hashtable = (Hashtable) hashTableAst.SafeGetValue();
             }
             catch (InvalidOperationException e)
             {

Original file line number	Diff line number	Diff line change
`@@ -462,9 +462,7 @@ private void parseSettingsFile(string settingsFilePath)`
`462`	`462`	`Hashtable hashtable;`
`463`	`463`	`try`
`464`	`464`	`{`
`465`		`- // ideally we should use HashtableAst.SafeGetValue() but since`
`466`		`- // it is not available on PSv3, we resort to our own narrow implementation.`
`467`		`- hashtable = Helper.GetSafeValueFromHashtableAst(hashTableAst);`
	`465`	`+ hashtable = (Hashtable) hashTableAst.SafeGetValue();`
`468`	`466`	`}`
`469`	`467`	`catch (InvalidOperationException e)`
`470`	`468`	`{`