fix(ph-ai): fix custom answer form tool

[kappa90]

Problem

The current implementation of the multi-question form is bugged, submitting a custom answer doesn't move to the next question.

Changes

• Renamed submitCustomAnswer action to advanceToNextQuestion for better clarity on its purpose
• Added logic to clear the custom input field and hide the input after capturing the value
• This ensures a clean state when users move to the next question in the form

How did you test this code?

Added tests

[kappa90]

• fix(ph-ai): fix custom answer form tool #42955 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: Redundant state clearing - advanceToNextQuestion() action already clears these via reducers (lines 39, 47)

Suggested change

	// Clear custom input and hide the input field after capturing the value
	actions.setCustomInput('')
	actions.setShowCustomInput(false)
	// State will be cleared by advanceToNextQuestion reducer

Prompt To Fix With AI

This is a comment left during a code review.
Path: frontend/src/scenes/max/messages/multiQuestionFormLogic.ts
Line: 99:101

Comment:
**style:** Redundant state clearing - `advanceToNextQuestion()` action already clears these via reducers (lines 39, 47)

```suggestion
            // State will be cleared by advanceToNextQuestion reducer
```

How can I resolve this? If you propose a fix, please make it concise.

[Copilot]

Pull request overview

This PR fixes a bug where submitting a custom answer in the multi-question form didn't move to the next question. The fix adds logic to clear the custom input field and hide it after submission, ensuring a clean state for the next question.

Key Changes:

• Added advanceToNextQuestion action to handle progression logic separately
• Updated reducers to clear customInput and hide showCustomInput when advancing
• Added explicit clearing logic in submitCustomAnswer listener for last-question scenario
• Added comprehensive test coverage for the form logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
frontend/src/scenes/max/messages/multiQuestionFormLogic.ts	Added advanceToNextQuestion action, updated reducers to clear input state on advancement, and added explicit clearing in submitCustomAnswer listener
frontend/src/scenes/max/messages/multiQuestionFormLogic.test.ts	Added comprehensive test suite covering option selection, custom answer submission, multi-question flows, and selector validation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The reducer for customInput now clears on advanceToNextQuestion, but the PR description states this action was renamed from submitCustomAnswer. However, submitCustomAnswer still exists as an action (line 22) and is still used throughout the codebase. This creates naming confusion.

The actual behavior is that submitCustomAnswer listener (line 89) calls advanceToNextQuestion action (line 107), which then triggers this reducer to clear the input. This is an indirect clearing mechanism that could be confusing for future maintainers.

Consider either:

1. Actually renaming submitCustomAnswer to a more appropriate name throughout the codebase if that was the intent, OR
2. Keeping submitCustomAnswer as-is and updating the PR description to reflect that advanceToNextQuestion is a new helper action, not a rename

[github-actions]

Size Change: 0 B

Total Size: 3.51 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	3.51 MB

_{compressed-size-action}