chore: opt into changeset-hygiene transitive re-exports#526
Merged
Conversation
Declares posthog-android and posthog-server as transitive re-exporters
of posthog so the hygiene check stops flagging them as 'extra' when
declared in a changeset alongside posthog without their own source
changes.
Both modules declare api(project(":posthog")) in Gradle and must
republish to deliver upstream core changes to their Maven consumers.
Config schema added in PostHog/.github#42.
Triggered by warning on #525.
marandaneto
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The changeset-hygiene check flags
posthog-androidandposthog-serveras "extra" when they're declared alongsideposthogwithout source changes of their own — see false positive on #525.But this is the correct pattern for our setup: both modules declare
api(project(":posthog"))in Gradle, so they must republish to deliver upstream core changes to their Maven consumers. The hygiene script can't see Gradle deps.The shared workflow now supports an opt-in config for this case: PostHog/.github#42.
💚 How did you test it?
Manually walked through the script logic against PR #525's diff:
affected={posthog}(onlyposthog/source changed)declared={posthog, posthog-android}posthogis in both →posthog-androidis excused from the "extra" check📝 Checklist