Skip to content

chore: opt into changeset-hygiene transitive re-exports#526

Merged
turnipdabeets merged 1 commit into
mainfrom
chore/changeset-hygiene-config
May 22, 2026
Merged

chore: opt into changeset-hygiene transitive re-exports#526
turnipdabeets merged 1 commit into
mainfrom
chore/changeset-hygiene-config

Conversation

@turnipdabeets
Copy link
Copy Markdown
Contributor

💡 Motivation and Context

The changeset-hygiene check flags posthog-android and posthog-server as "extra" when they're declared alongside posthog without source changes of their own — see false positive on #525.

But this is the correct pattern for our setup: both modules declare api(project(":posthog")) in Gradle, so they must republish to deliver upstream core changes to their Maven consumers. The hygiene script can't see Gradle deps.

The shared workflow now supports an opt-in config for this case: PostHog/.github#42.

💚 How did you test it?

Manually walked through the script logic against PR #525's diff:

  • affected = {posthog} (only posthog/ source changed)
  • declared = {posthog, posthog-android}
  • With this config, posthog is in both → posthog-android is excused from the "extra" check
  • Result: no warning comment posted

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

Declares posthog-android and posthog-server as transitive re-exporters
of posthog so the hygiene check stops flagging them as 'extra' when
declared in a changeset alongside posthog without their own source
changes.

Both modules declare api(project(":posthog")) in Gradle and must
republish to deliver upstream core changes to their Maven consumers.

Config schema added in PostHog/.github#42.
Triggered by warning on #525.
@turnipdabeets turnipdabeets requested a review from a team as a code owner May 21, 2026 22:30
@turnipdabeets turnipdabeets enabled auto-merge (squash) May 21, 2026 22:37
@turnipdabeets turnipdabeets merged commit 9165c3d into main May 22, 2026
13 checks passed
@turnipdabeets turnipdabeets deleted the chore/changeset-hygiene-config branch May 22, 2026 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants