Skip to content

Commit c0e5012

Browse files
committed
Fix PSScriptAnalyzer warnings in Update-AliasesToExport and Add-Parameter
1 parent b9cb30d commit c0e5012

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

Source/Public/Add-Parameter.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ function Add-Parameter {
174174
}
175175

176176
Write-Debug "Existing parameters: $($Ast.Parameters.Name -join ', ')"
177-
$global:ParameterSource = $this.ParameterSource
177+
# $global:ParameterSource = $this.ParameterSource
178178
$Additional = $this.ParameterSource.Parameters.Where{ $_.Name -notin ([string[]]$Ast.Parameters.Name) }
179179
Write-Debug "Additional parameters from boilerplate: $($Additional.Count)"
180180
if (($Text = $Additional.Text -join ",`n`n")) {

Source/Public/Update-AliasesToExport.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function Update-AliasesToExport {
1010
1111
This function never outputs any TextReplacements
1212
#>
13-
[CmdletBinding()]
13+
[CmdletBinding(SupportsShouldProcess)]
1414
[OutputType([TextReplacement])]
1515
param(
1616
# The AST of the root script module to find aliases in
@@ -143,7 +143,7 @@ function Update-AliasesToExport {
143143
process {
144144
$Visitor = [AliasExportGenerator]::new()
145145
$ScriptModule.Visit($Visitor)
146-
Update-Metadata -Path $ModuleManifest -PropertyName AliasesToExport -Value $Visitor.Aliases
146+
Update-Metadata -Path $ModuleManifest -PropertyName AliasesToExport -Value $Visitor.Aliases -WhatIf:$WhatIfPreference -Confirm:($ConfirmPreference -eq 'Low')
147147
}
148148
}
149149

0 commit comments

Comments
 (0)