Merge pull request #15 from DurieuxPol/fix/jacobi

Improved JacobiTransformation

Author: jordanmontt

src/Math-Matrix-Tests/PMJacobiTransformationTest.class.st

@@ -15,7 +15,7 @@ PMJacobiTransformationTest >> testEigenvalueOfIdentityMatrixIsOne [
 	jacobiTransformation := PMJacobiTransformation matrix: identityMatrix.
 
 	expected := #(1 1).
-	self assert: jacobiTransformation evaluate equals: expected
+	self assert: jacobiTransformation eigenValues equals: expected
 ]
 
 { #category : 'tests' }
@@ -26,7 +26,7 @@ PMJacobiTransformationTest >> testEigenvectorsOfIdentityMatrixAreTheUnitVectors
 	identityMatrix := PMMatrix rows: #(#(1 0) #(0 1)).
 	jacobiTransform := PMJacobiTransformation matrix: identityMatrix.
 
-	matrixOfEigenvectors := jacobiTransform transform.
+	matrixOfEigenvectors := jacobiTransform eigenVectors.
 
 	expected := PMSymmetricMatrix identity: 2.
 	self assert: matrixOfEigenvectors equals: expected.

src/Math-Matrix-Tests/PMMatrixTest.class.st

@@ -193,9 +193,8 @@ PMMatrixTest >> testEigenvalues [
 	expectedEigenvalues := #(8.105482616526306 4.776537928330764 2.1179794551429305).
 
 	finder := PMJacobiTransformation matrix: matrix.
-	finder desiredPrecision: 1.0e-09.
 
-	eigenvalues := finder evaluate.
+	eigenvalues := finder eigenValues.
 
 	eigenvalues with: expectedEigenvalues do: [ :actual :expected |
 		self assert: actual closeTo: expected ].

src/Math-Matrix-Tests/PMSingularValueDecompositionTest.class.st

@@ -63,7 +63,7 @@ PMSingularValueDecompositionTest class >> loadExamples [
 	example4 := PMSingularValueDecompositionExample
 		            newMatrix: (PMMatrix rows: #( #( 1 0 0 0 2 ) #( 0 0 3 0 0 ) #( 0 0 0 0 0 ) #( 0 2 0 0 0 ) ))
 		            u: (PMMatrix rows: #( #( 0 1 0 0 ) #( 1 0 0 0 ) #( 0 0 0 1 ) #( 0 0 1 0 ) ))
-		            v: (PMMatrix rows: { { 0. 0.2 sqrt. 0. 0.8 sqrt. 0 }. { 0. 0. 1. 0. 0 }. { 1. 0. 0. 0. 0 }. { 0. 0. 0. 0. 1 }. { 0. 0.8 sqrt. 0. 0.2 sqrt negated. 0 } })
+		            v: (PMMatrix rows: { { 0. 0.2 sqrt. 0. 0. 0.8 sqrt }. { 0. 0. 1. 0. 0 }. { 1. 0. 0. 0. 0 }. { 0. 0. 0. 1. 0 }. { 0. 0.8 sqrt. 0. 0. 0.2 sqrt negated } })
 		            s: (PMMatrix rows: { { 3. 0. 0. 0. 0 }. { 0. 5 sqrt. 0. 0. 0 }. { 0. 0. 2. 0. 0 }. { 0. 0. 0. 0. 0 } }).
 ]