Skip to content

fix: glass not showing under NavigationMenuContent; tweak: header icons size #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Diubii merged 4 commits into from
May 24, 2026
+8 −6
Merged

fix: glass not showing under NavigationMenuContent; tweak: header icons size #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0aa248
tweak: header icons size
Diubii May 22, 2026
edb672d
fix: glass effect on NavigationMenuContent
Diubii May 22, 2026
099c628
tweak: chevron size
Diubii May 22, 2026
4577982
remove: size attribute in Icon element both in IconsButtonDesktop and…
Diubii May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/header/desktop-layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,12 @@ export const DesktopLayout = () => {
const customHoverEffectClass = "hover:underline focus:underline decoration-1 decoration-blue-secondary "

return (
<Glass className="fixed inset-x-6 top-10 z-20 mx-auto box-border max-w-261.25 rounded-full px-17.5 py-5">
<div className="fixed inset-x-6 top-10 z-20 mx-auto box-border max-w-261.25 rounded-full">
<Glass className="pointer-events-none absolute inset-0 rounded-full" />

<NavigationMenu
viewport={false}
className="top-0 isolate flex max-w-full shrink-0 items-stretch bg-card [&>div]:w-full"
className="relative top-0 flex max-w-full shrink-0 items-stretch bg-transparent px-17.5 py-5 [&>div]:w-full"
>
<NavigationMenuList className="flex w-full justify-between">
<NavigationMenuLink asChild className={cn("p-0 py-0.75", removeDefaultHoverEffectClass)}>
Expand All @@ -47,7 +49,7 @@ export const DesktopLayout = () => {
<span className="typo-body-medium font-red-hat text-text-primary">{item.title}</span>
</div>
<FiChevronDown
size={24}
size={16}
className="relative top-px ml-1 text-text-primary transition duration-300 group-data-[state=open]:rotate-180"
/>
</NavigationMenuTrigger>
Expand Down Expand Up @@ -106,6 +108,6 @@ export const DesktopLayout = () => {
</NavigationMenuItem>
</NavigationMenuList>
</NavigationMenu>
</Glass>
</div>
)
}
4 changes: 2 additions & 2 deletions src/components/header/icon-buttons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const IconButtonsMobile = () => (
<>
{iconConfigs.map(({ key, label, Icon, onClick }) => (
<button key={key} type="button" onClick={onClick} aria-label={label}>
<Icon size={24} className="text-black" />
<Icon className="size-[24px] text-text-primary" />
</button>
))}
</>
Expand All @@ -23,7 +23,7 @@ export const IconButtonsDesktop = ({ removeHoverClass }: { removeHoverClass: str
{iconConfigs.map(({ key, label, Icon, onClick }) => (
<NavigationMenuLink key={key} asChild className={cn("p-0", removeHoverClass)}>
<button type="button" onClick={onClick} aria-label={label}>
<Icon size={24} className="size-[24px] text-text-primary" />
<Icon className="size-[20px] text-text-primary" />
</button>
</NavigationMenuLink>
))}
Expand Down
Loading